[GitHub] [hudi] SteNicholas commented on a diff in pull request #8437: [HUDI-6066] HoodieTableSource supports parquet predicate push down

["SteNicholas (via GitHub)" <gi...@apache.org>]

SteNicholas commented on code in PR #8437:
URL: https://github.com/apache/hudi/pull/8437#discussion_r1290959520


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/RecordIterators.java:
##########
@@ -80,12 +104,42 @@ public static ClosableIterator<RowData> getParquetRecordIterator(
               batchSize,
               path,
               splitStart,
-              splitLength));
+              splitLength,
+              filterPredicate,
+              recordFilter));
       if (castProjection.isPresent()) {
         return new SchemaEvolvedRecordIterator(itr, castProjection.get());
       } else {
         return itr;
       }
     }
   }
+
+  private static FilterPredicate getFilterPredicate(Configuration configuration) {
+    try {
+      return SerializationUtil.readObjectFromConfAsBase64(FILTER_PREDICATE, configuration);
+    } catch (IOException e) {

Review Comment:
   @danny0405, the filters could be passed to Hadoop's configuration entries prefixed with `FILTER_PREDICATE` that is `parquet.private.read.filter.predicate` for `HoodieTableSource#getParquetConf` and used by one of the available readers, `VectorizedParquetRecordReader` or `ParquetRecordReader`. Meanwhile, `UNBOUND_RECORD_FILTER` which is `parquet.read.filter` is used for native parquet read filter cofiguration.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org