You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2016/04/27 16:31:39 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1232: Write a tutorial...
GitHub user okram opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/296
TINKERPOP-1232: Write a tutorial demonstrating the 3 ways to write a Gremlin language variant.
https://issues.apache.org/jira/browse/TINKERPOP-1232
A tutorial demonstrating how to embed Gremlin in a host language. The tutorial explains how to do this for both Jython and Python. The reflection-based model proposed should easily map over to other languages such as Ruby, JavaScript, and PHP. As long as this model is sufficient for these languages, then I think we have a solid tutorial.
Also, I went through all the `index.asciidoc` files in our `docs/` and made the Apache TinkerPop logo HREF to http://tinkerpop.apache.org and added `*x.y.z*` so they all have a version number.
The tutorial has been published here for review:
http://tinkerpop.apache.org/docs/3.2.1-SNAPSHOT/tutorials/gremlin-language-variants/
VOTE +1 (`bin/publish-docs.sh` worked)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1232
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit f2c1d01df7e45be0d7d2e3175f4a9d987163901c
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-04-19T14:23:12Z
Added stub for gremlin language variants tutorial.
commit 0beae616352271f74e92bfeb6d1100856e7996e0
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-19T17:38:42Z
started to flesh out the gremlin-language-variant tutorial.
commit 7e2833c8fcca2a4245785788410712be8439ad91
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-20T14:18:52Z
added Gremlin-Jython work for the first model based on the JVM. Also, added gremlin-jython.py as a resource people can now use. an artifact of the tutorial.
commit d5a06d99f3df520ad5cecf2fb21c7ac8ad223592
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-20T15:28:33Z
more work on Gremlin-Jython. This is a really cool tutorial.
commit 57210e98678dba6b2e3f1adb8306a7a0bae82eea
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-20T18:22:14Z
more work on language variant tutorial. I created a section called Language Driver vs. Language Variant and articulate why this divide needs to be held by the community.
commit 87834bdc42246005326b92cf33f3095f756b3ac7
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-20T20:20:16Z
added pure Python string model and gremlin-python.py.
commit 4eb6113fcc0d1bce66ffb7611d2ee824b7de9740
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-20T23:13:09Z
using gremlin-python websockets driver by david brown. it just works. however, had to easy_install pip and do some setup.py junk.. but once that was done, bammers.
commit 62fa995d8e38b80638e62081e98e7070675bede0
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-21T01:41:26Z
integrated the GremlinServer string text better with the example.
commit 738a662b1b738a6aac70ac343fbe0d0ae16fda61
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-21T13:06:35Z
lot more work on the tutorial. added fun graphics too :).
commit b66d736076bd25ad2554a92b09bfe88c834afd0d
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-21T13:11:25Z
forgot to commit the new graphics.
commit cbf6cc19321fd3375c5d910a9454ab75e722214c
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-21T13:17:05Z
syncd with master
commit ce1adcedc12f3c630f284c8caee293342c465e23
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-21T14:35:06Z
finished the tutorial. Its epic.
commit 099e110a22c94d987a0af17c71b961bf91edad75
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-21T15:00:12Z
added latest version of the gremlin-python generated source file.
commit cc66ba5f8a42e6fd0b130adb87ed8d4702674491
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-21T15:38:31Z
minor nothings -- just added links and some internal ahref anchors.
commit 343a34bc6a4bb07dc0e61604c811107f00530b33
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-21T15:41:39Z
sorry. another minor nothing. done for the day with this.
commit adce6cfada83f1593a3fda13f8dcfac579d2fcc5
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-21T17:22:16Z
one more run through -- tessted all the code chunks again (found a bug in the Jython section -- phew. fixed). Added some text about gremlin-lang-driver and gremlin-lang naming conventions. A few more code call outs, but not as many as I would like.
commit b5efb2a2aa96fcfe77dd31e5d7dba3798f3dd16e
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-27T14:24:29Z
All the index.asciidocs of the docs now have the TinkerPop logo HREF to tinkerpop.apache.org. Also, they have x.y.z version numbers like the reference docs. Finished up gremlin-language-variants tutorial. Ketrina has a banner graphic for the tutorial coming in a couple of weeks that I will CTR add then.
commit 0bf7156f779b169066b61236b715518501a16622
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-04-27T14:27:02Z
updated CHANGELOG and merged master.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1232: Write a tutorial...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/296#issuecomment-215225276
`docker/build.sh -d` successfully finished. Everything's looking good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1232: Write a tutorial...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/296#issuecomment-215168374
This line doesn't seem completely accurate to me:
> Jython is a JSR-223 ScriptEngine implementation that enables the evaluation of Python on the Java virtual machine.
Jython provides a JSR-223 implementation but isn't Jython on its own much more than that?
Something else I hadn't thought of before. We refer to all of this generated code as `gremlin-python` but there's actually two distinct sets of classes at play - one that works directly with the JVM and one that creates groovy scripts for submission over `RemoteConnection`. Seems like there should be some distinction in naming there whether at the class level or the module level. Maybe this doesn't matter for the tutorial, but does matter on implementation of TINKERPOP-1278 ?
Anyway, despite my thoughts/questions - this is an good tutorial and an important one for organizing the community into something coherent around these issues.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1232: Write a tutorial...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/296#issuecomment-215191048
> Regarding naming, there are two classes: gremlin-jython.py (which is all JVM-based) and gremlin-python.py
oops - missed that.
> I would suspect any JVM-based language is automagically using the JVM model
agreed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1232: Write a tutorial...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/296#issuecomment-215185511
A changed "is a" to "provides".
Regarding naming, there are two classes: `gremlin-jython.py` (which is all JVM-based) and `gremlin-python.py` (which is all `String` construction based). Thus,we DO have a distinction in naming. I would suspect any JVM-based language is automagically using the JVM model -- e.g. Gremlin-Clojure, Gremlin-Scala, ?Gremlin-Rhino? :(, Gremlin-Jython, Gremlin-JRuby, Gremlin-Groovy...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1232: Write a tutorial...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---