[GitHub] [solr] epugh commented on a change in pull request #218: SOLR-15536: Rewrite /c//shards v2 APIs using annotations

[GitBox <gi...@apache.org>]

epugh commented on a change in pull request #218:
URL: https://github.com/apache/solr/pull/218#discussion_r669079557



##########
File path: solr/core/src/java/org/apache/solr/handler/admin/api/SplitShardAPI.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.handler.admin.api;
+
+import org.apache.commons.collections.MapUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.solr.api.Command;
+import org.apache.solr.api.EndPoint;
+import org.apache.solr.api.PayloadObj;
+import org.apache.solr.client.solrj.request.beans.AddReplicaPropertyPayload;
+import org.apache.solr.client.solrj.request.beans.SplitShardPayload;
+import org.apache.solr.common.params.CollectionParams;
+import org.apache.solr.common.params.CommonAdminParams;
+import org.apache.solr.handler.admin.CollectionsHandler;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.apache.solr.client.solrj.SolrRequest.METHOD.POST;
+import static org.apache.solr.common.params.CollectionAdminParams.COLLECTION;
+import static org.apache.solr.common.params.CollectionAdminParams.PROPERTY_PREFIX;
+import static org.apache.solr.common.params.CommonParams.ACTION;
+import static org.apache.solr.handler.ClusterAPI.wrapParams;
+import static org.apache.solr.security.PermissionNameProvider.Name.COLL_EDIT_PERM;
+
+/**
+ * V2 API for splitting an existing shard up into multiple pieces.
+ *
+ * This API (POST /v2/collections/collectionName/shards {'split': {...}}) is analogous to the v1
+ * /admin/collections?action=SPLITSHARD command.
+ *
+ * @see SplitShardPayload
+ */
+@EndPoint(
+        path = {"/c/{collection}/shards", "/collections/{collection}/shards"},
+        method = POST,
+        permission = COLL_EDIT_PERM)
+public class SplitShardAPI {
+  private static final String V2_SPLIT_CMD = "split";
+
+  private final CollectionsHandler collectionsHandler;
+
+  public SplitShardAPI(CollectionsHandler collectionsHandler) {
+    this.collectionsHandler = collectionsHandler;
+  }
+
+  @Command(name = V2_SPLIT_CMD)
+  public void splitShard(PayloadObj<SplitShardPayload> obj) throws Exception {
+    final SplitShardPayload v2Body = obj.get();
+    final Map<String, Object> v1Params = v2Body.toMap(new HashMap<>());
+    v1Params.put(ACTION, CollectionParams.CollectionAction.SPLITSHARD.toLower());
+    v1Params.put(COLLECTION, obj.getRequest().getPathTemplateValues().get(COLLECTION));
+
+    if (StringUtils.isNotEmpty(v2Body.splitKey)) {
+      v1Params.put(CommonAdminParams.SPLIT_KEY, v2Body.splitKey);
+    }
+    if (MapUtils.isNotEmpty(v2Body.coreProperties)) {
+      flattenMapWithPrefix(v2Body.coreProperties, v1Params, PROPERTY_PREFIX);
+    }
+    collectionsHandler.handleRequestBody(wrapParams(obj.getRequest(), v1Params), obj.getResponse());
+  }
+
+  private void flattenMapWithPrefix(Map<String, Object> toFlatten, Map<String, Object> destination,

Review comment:
       Should this method `flattenMapWithPrefix` be shared?    I know some projects have a really strong "DRY" feeling, and others, it's okay to share. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org