You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/11/23 09:14:59 UTC

[GitHub] spark pull request #23125: [SPARK-26156][WebUI] Revise summary section of st...

GitHub user gengliangwang opened a pull request:

    https://github.com/apache/spark/pull/23125

    [SPARK-26156][WebUI] Revise summary section of stage page

    ## What changes were proposed in this pull request?
    In the summary section of stage page:
    ![image](https://user-images.githubusercontent.com/1097932/48935518-ebef2b00-ef42-11e8-8672-eaa4cac92c5e.png)
    
    1.  the following metrics names can be revised:
    Output => Output Size / Records
    Shuffle Read: => Shuffle Read Size / Records
    Shuffle Write => Shuffle Write Size / Records
    
    After changes, the names are more clear, and consistent with the other names in the same page.
    
    2. The associated job id URL should not contain the 3 tails spaces. Reduce the number of spaces to one, and exclude the space from link. This is consistent with SQL execution page.
    
    ## How was this patch tested?
    
    Manual check:
    ![image](https://user-images.githubusercontent.com/1097932/48935538-f7425680-ef42-11e8-8b2a-a4f388d3ea52.png)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gengliangwang/spark reviseStagePage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23125
    
----
commit 215d3d7b8e187716d68a67a9b16d9eb444a8099f
Author: Gengliang Wang <ge...@...>
Date:   2018-11-23T09:04:38Z

    revise stage page

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #23125: [SPARK-26156][WebUI] Revise summary section of st...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23125#discussion_r235924136
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -79,6 +79,9 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We
         localityNamesAndCounts.sorted.mkString("; ")
       }
     
    +  private def jobURL(request: HttpServletRequest, jobId: Int): String =
    --- End diff --
    
    It all looks fine except I don't see a lot of value in moving this into a method that's used once. It just moves the logic to a separate part of the file.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    Merged to master


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    **[Test build #99216 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99216/testReport)** for PR 23125 at commit [`a2d7c7a`](https://github.com/apache/spark/commit/a2d7c7a39c265ce41882f3bef1363af4c3962cdb).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    **[Test build #99216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99216/testReport)** for PR 23125 at commit [`a2d7c7a`](https://github.com/apache/spark/commit/a2d7c7a39c265ce41882f3bef1363af4c3962cdb).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99216/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    **[Test build #99214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99214/testReport)** for PR 23125 at commit [`215d3d7`](https://github.com/apache/spark/commit/215d3d7b8e187716d68a67a9b16d9eb444a8099f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99214/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5308/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by gengliangwang <gi...@git.apache.org>.

Github user gengliangwang commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    @srowen @vanzin 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23125: [SPARK-26156][WebUI] Revise summary section of stage pag...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23125
  
    **[Test build #99214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99214/testReport)** for PR 23125 at commit [`215d3d7`](https://github.com/apache/spark/commit/215d3d7b8e187716d68a67a9b16d9eb444a8099f).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org