[GitHub] [apisix] jiangfucheng commented on a diff in pull request #9784: refactor: move global_rules to separate file

["jiangfucheng (via GitHub)" <gi...@apache.org>]

jiangfucheng commented on code in PR #9784:
URL: https://github.com/apache/apisix/pull/9784#discussion_r1257403194


##########
apisix/global_rules.lua:
##########
@@ -0,0 +1,56 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core    = require("apisix.core")
+local plugin_checker = require("apisix.plugin").plugin_checker
+local error = error
+
+
+local _M = {}
+
+local global_rules
+
+function _M.init_worker()
+    local err
+    global_rules, err = core.config.new("/global_rules", {
+        automatic = true,
+        item_schema = core.schema.global_rule,
+        checker = plugin_checker,
+    })
+    if not global_rules then
+        error("failed to create etcd instance for fetching /global_rules : "
+            .. err)
+    end
+end
+
+
+function _M.global_rules()
+    if not global_rules then
+        return nil, nil
+    end
+    return global_rules.values, global_rules.conf_version

Review Comment:
   I want keep consistent code style with other resources, It allows the caller to use same logic to process all resources when we needed it. (like upstream `delete_checker()` method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org