[GitHub] spark pull request #19224: [SPARK-20990][SQL] Read all JSON documents in fil...

[attilapiros <gi...@git.apache.org>]

Github user attilapiros commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19224#discussion_r161567546
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala ---
    @@ -361,3 +361,78 @@ class JacksonParser(
         }
       }
     }
    +
    +object JacksonParser {
    +  private[spark] def splitDocuments(input: InputStream) = new Iterator[String] {
    +
    +    private implicit class JsonCharacter(char: Char) {
    --- End diff --
    
    nit: You can spare this implicit class by having isJsonObjectFinished method with the two parameters. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org