You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/09/11 17:39:02 UTC
[Impala-ASF-CR] Avoid python26-ism in get query locations()
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11419
Change subject: Avoid python26-ism in get_query_locations()
......................................................................
Avoid python26-ism in get_query_locations()
A recent change used a python27+ mechanism to create
a dict with a list comprehension. This updates it
to the python26-friendly way.
Change-Id: Ie3457e6d97d2f6e55fc54040b4c6801343ffbb46
---
M tests/common/impala_service.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/11419/1
--
To view, visit http://gerrit.cloudera.org:8080/11419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3457e6d97d2f6e55fc54040b4c6801343ffbb46
Gerrit-Change-Number: 11419
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] Avoid python26-ism in get query locations()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11419 )
Change subject: Avoid python26-ism in get_query_locations()
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3457e6d97d2f6e55fc54040b4c6801343ffbb46
Gerrit-Change-Number: 11419
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Sep 2018 21:08:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Avoid python26-ism in get query locations()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11419 )
Change subject: Avoid python26-ism in get_query_locations()
......................................................................
Avoid python26-ism in get_query_locations()
A recent change used a python27+ mechanism to create
a dict with a list comprehension. This updates it
to the python26-friendly way.
Change-Id: Ie3457e6d97d2f6e55fc54040b4c6801343ffbb46
Reviewed-on: http://gerrit.cloudera.org:8080/11419
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_service.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bikramjeet Vig: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3457e6d97d2f6e55fc54040b4c6801343ffbb46
Gerrit-Change-Number: 11419
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Avoid python26-ism in get query locations()
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11419 )
Change subject: Avoid python26-ism in get_query_locations()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3457e6d97d2f6e55fc54040b4c6801343ffbb46
Gerrit-Change-Number: 11419
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Sep 2018 17:54:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Avoid python26-ism in get query locations()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11419 )
Change subject: Avoid python26-ism in get_query_locations()
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/639/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3457e6d97d2f6e55fc54040b4c6801343ffbb46
Gerrit-Change-Number: 11419
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Sep 2018 18:12:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Avoid python26-ism in get query locations()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11419 )
Change subject: Avoid python26-ism in get_query_locations()
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3144/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3457e6d97d2f6e55fc54040b4c6801343ffbb46
Gerrit-Change-Number: 11419
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Sep 2018 17:39:28 +0000
Gerrit-HasComments: No