You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/01/25 03:40:37 UTC
[GitHub] [cordova-android] erisu commented on a change in pull request #1157: GH-1156: Restore key event handlers when a DOM element is fullscreen
erisu commented on a change in pull request #1157:
URL: https://github.com/apache/cordova-android/pull/1157#discussion_r563447227
##########
File path: framework/src/org/apache/cordova/CordovaWebViewImpl.java
##########
@@ -255,7 +255,12 @@ public WrapperView(Context context, CordovaWebViewEngine engine) {
@Override
public boolean dispatchKeyEvent(KeyEvent event) {
- return engine.getView().dispatchKeyEvent(event);
+ boolean ret = engine.getView().dispatchKeyEvent(event);
+ if (! ret) {
Review comment:
```suggestion
if (!ret) {
```
That space :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org