You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "anandghegde (via GitHub)" <gi...@apache.org> on 2026/09/13 15:45:33 UTC

[PR] Move temporal cast helpers into a private submodule [arrow-rs]

anandghegde opened a new pull request, #11075:
URL: https://github.com/apache/arrow-rs/pull/11075

   # Which issue does this PR close?
   
   Part of #11032 — this is the **temporal helpers** group only, so it does not
   close the issue. The remaining groups (numeric/boolean, binary/byte-view,
   struct, decimal adapters) are untouched here. @amitvijapur mentioned taking the
   struct group; this branch does not touch it.
   
   # Rationale for this change
   
   `arrow-cast/src/cast/mod.rs` is ~14k lines. #5125 moved list, decimal,
   dictionary, string, map, run-array and union support into private submodules,
   and #11032 captures the groups still left inline. The timestamp, date,
   duration, interval and timezone helpers are one such cohesive group.
   
   # What changes are included in this PR?
   
   A new private `arrow-cast/src/cast/temporal.rs` holding:
   
   - `cast_interval_year_month_to_interval_month_day_nano`
   - `cast_interval_day_time_to_interval_month_day_nano`
   - `cast_month_day_nano_to_duration`
   - `cast_duration_to_interval`
   - `make_timestamp_array`, `make_duration_array`
   - `as_time_res_with_timezone`
   - `timestamp_to_date32`
   - `adjust_timestamp_to_timezone`
   
   `cast_with_options` stays the top-level dispatcher in `mod.rs`.
   
   Two things worth flagging for review:
   
   - **`cast_reinterpret_arrays` deliberately stays in `mod.rs`.** It sits in the
     middle of this block, so it looks like part of the group, but it is a generic
     `PrimitiveArray::reinterpret_cast` wrapper with 23 call sites across the
     numeric, temporal and dictionary paths — not temporal-specific.
   - **The helpers became `pub(crate)`**, which is what they need to stay reachable
     from `mod.rs` through the glob import, matching `string.rs` and `list.rs`.
     Nothing new is exposed outside the crate.
   
   The bodies are moved verbatim. I checked this mechanically rather than by eye:
   extracting the three original line ranges from `HEAD` and normalising away the
   `pub(crate)` prefix gives a byte-identical match against the new file.
   
   # Are these changes tested?
   
   Covered by the existing `arrow-cast` tests — this is a code move, so no new
   tests are warranted and no test was modified.
   
   ```
   cargo test -p arrow-cast     379 passed + 12 passed, 0 failed (same as base)
   cargo clippy -p arrow-cast --all-targets -- -D warnings   clean
   cargo fmt -p arrow-cast -- --check                        clean
   cargo build -p arrow                                      builds
   ```
   
   Run on macOS 26.6.2, aarch64-apple-darwin, toolchain 1.98.1 from
   `rust-toolchain.toml`.
   
   # Are there any user-facing changes?
   
   No. No public API change, no behavioural change. Everything moved is private to
   the crate, and the two `mod.rs` imports dropped (`IntervalMonthDayNano`, and
   `NaiveTime`/`Offset` from `chrono`) were orphaned by the move.
   
   # AI usage disclosure
   
   Written with AI assistance (Claude). The AI performed the mechanical extraction
   and ran the verification above; I reviewed the result and own the change.
   
   To be concrete about what that means here, since the value of a code move is
   entirely in it being faithful: the moved bodies are unedited, and the
   byte-identity check described above is the evidence for that rather than a
   reading. The two judgement calls — leaving `cast_reinterpret_arrays` behind, and
   the `pub(crate)` visibility — are called out above precisely because they are the
   parts a diff of a "pure move" would not otherwise draw attention to.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "anandghegde (via GitHub)" <gi...@apache.org>.
anandghegde commented on PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075#issuecomment-5958827536

   Merged `main` up and resolved the conflicts — upstream's newer versions of the moved code (the DST-aware `adjust_timestamp_to_timezone` and `resolve_local_offset`) now live in the `temporal` submodule. `cargo test -p arrow-cast` (417 tests), clippy and fmt are clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075#issuecomment-6005218584

   🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/11075#issuecomment-6004721301)
   
   **Target:** cast&#95;kernels
   
   Comparing extract-temporal-cast-helpers (941682a14681cd549c353361e9261c0ab7899f3a) to 103ebe7 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/103ebe7548db35c37e8ff35fcb02438bcd182fa7..941682a14681cd549c353361e9261c0ab7899f3a)
   
   <details><summary>Run configuration</summary>
   
   ```yaml
   run benchmark cast_kernels
   shards: 1
   
   ```
   
   </details>
   
   <details><summary>Details</summary>
   
   ```
   group                                                              base                                   changed
   -----                                                              ----                                   -------
   "cast decimal128 to float64"                                       1.00     27.1±0.01µs        ? ?/sec    1.00     27.1±0.03µs        ? ?/sec
   "cast decimal128 to int64"                                         1.01     48.4±0.74µs        ? ?/sec    1.00     48.0±0.35µs        ? ?/sec
   "cast decimal128 to int8"                                          1.01     63.0±2.79µs        ? ?/sec    1.00     62.2±2.10µs        ? ?/sec
   "cast decimal256 to float64"                                       1.00     56.8±0.03µs        ? ?/sec    1.00     56.8±0.03µs        ? ?/sec
   "cast decimal256 to int64"                                         1.00    137.6±0.56µs        ? ?/sec    1.00    137.9±0.73µs        ? ?/sec
   "cast float64 to decimal128(32, 3)"                                1.00     27.7±0.02µs        ? ?/sec    1.02     28.1±0.02µs        ? ?/sec
   "cast invalid float64 to to decimal128(32, 3)"                     1.00     10.7±0.01µs        ? ?/sec    1.00     10.7±0.01µs        ? ?/sec
   "cast string to decimal128(38, 3)"                                 1.02     86.1±0.33µs        ? ?/sec    1.00     84.4±0.46µs        ? ?/sec
   "cast string to decimal256(76, 3)"                                 1.00    138.0±0.55µs        ? ?/sec    1.00    137.8±0.66µs        ? ?/sec
   cast binary dict to string view (sparse)                           1.04     47.9±2.44µs        ? ?/sec    1.00     46.2±0.09µs        ? ?/sec
   cast binary to dict high cardinality                               1.00    223.3±0.17µs        ? ?/sec    1.00    223.3±0.18µs        ? ?/sec
   cast binary to dict high cardinality no nulls                      1.00    164.6±0.25µs        ? ?/sec    1.00    165.3±0.37µs        ? ?/sec
   cast binary to dict low cardinality                                1.00    191.4±0.15µs        ? ?/sec    1.00    191.7±0.10µs        ? ?/sec
   cast binary to dict low cardinality no nulls                       1.00    131.8±0.23µs        ? ?/sec    1.01    133.1±0.31µs        ? ?/sec
   cast binary to dict medium cardinality                             1.00    193.3±0.16µs        ? ?/sec    1.00    193.6±0.09µs        ? ?/sec
   cast binary to dict medium cardinality no nulls                    1.00    133.7±0.21µs        ? ?/sec    1.01    135.1±0.30µs        ? ?/sec
   cast binary view to string                                         1.04     70.4±2.95µs        ? ?/sec    1.00     67.6±0.65µs        ? ?/sec
   cast binary view to string view                                    1.00     63.8±2.03µs        ? ?/sec    1.00     63.7±0.93µs        ? ?/sec
   cast binary view to wide string                                    1.02     69.4±0.54µs        ? ?/sec    1.00     68.1±0.65µs        ? ?/sec
   cast bool to int32 8192                                            1.00   1092.9±2.10ns        ? ?/sec    1.00   1097.0±4.36ns        ? ?/sec
   cast bool to string 8192                                           1.02     50.6±0.58µs        ? ?/sec    1.00     49.7±0.43µs        ? ?/sec
   cast bool to string no nulls 8192                                  1.02     40.1±0.63µs        ? ?/sec    1.00     39.2±0.48µs        ? ?/sec
   cast bool to string view 8192                                      1.01     67.1±0.74µs        ? ?/sec    1.00     66.7±0.33µs        ? ?/sec
   cast bool to string view no nulls 8192                             1.00     59.8±1.09µs        ? ?/sec    1.05     62.8±3.89µs        ? ?/sec
   cast date to string                                                1.01    498.9±9.33µs        ? ?/sec    1.00    495.7±8.26µs        ? ?/sec
   cast date32 to date64 512                                          1.00    337.1±0.44ns        ? ?/sec    1.00    336.7±3.29ns        ? ?/sec
   cast date64 to date32 512                                          1.00    818.8±1.48ns        ? ?/sec    1.00    816.5±2.88ns        ? ?/sec
   cast decimal128 to decimal128 512                                  1.00      6.9±0.01µs        ? ?/sec    1.00      6.9±0.01µs        ? ?/sec
   cast decimal128 to decimal128 512 lower precision                  1.00     17.9±0.14µs        ? ?/sec    1.00     17.9±0.16µs        ? ?/sec
   cast decimal128 to decimal128 512 with lower scale (infallible)    1.00     45.5±0.03µs        ? ?/sec    1.00     45.7±0.09µs        ? ?/sec
   cast decimal128 to decimal128 512 with same scale                  1.01     79.2±4.09ns        ? ?/sec    1.00     78.2±6.42ns        ? ?/sec
   cast decimal128 to decimal256 512                                  1.00     26.2±0.03µs        ? ?/sec    1.00     26.2±0.03µs        ? ?/sec
   cast decimal256 to decimal128 512                                  1.00    298.2±0.39µs        ? ?/sec    1.00    298.2±0.29µs        ? ?/sec
   cast decimal256 to decimal256 512                                  1.00     98.0±0.38µs        ? ?/sec    1.00     97.9±0.20µs        ? ?/sec
   cast decimal256 to decimal256 512 with same scale                  1.00     78.9±2.66ns        ? ?/sec    1.04     81.7±6.83ns        ? ?/sec
   cast dict to string view                                           1.14     12.2±0.01µs        ? ?/sec    1.00     10.7±0.05µs        ? ?/sec
   cast dict to string view (sparse)                                  1.00      5.2±0.06µs        ? ?/sec    1.00      5.2±0.06µs        ? ?/sec
   cast f32 to string 512                                             1.00     11.7±0.04µs        ? ?/sec    1.02     12.0±0.05µs        ? ?/sec
   cast f64 to string 512                                             1.00     15.4±0.03µs        ? ?/sec    1.00     15.4±0.04µs        ? ?/sec
   cast float32 to int32 512                                          1.02    622.7±0.75ns        ? ?/sec    1.00    611.6±2.54ns        ? ?/sec
   cast float64 to float32 512                                        1.00    170.1±0.73ns        ? ?/sec    1.01    171.8±3.49ns        ? ?/sec
   cast float64 to uint64 512                                         1.00    629.9±0.84ns        ? ?/sec    1.01    634.6±3.81ns        ? ?/sec
   cast i64 to string 512                                             1.00      8.8±0.03µs        ? ?/sec    1.00      8.8±0.03µs        ? ?/sec
   cast int32 to bool 8192                                            1.00   1596.6±2.99ns        ? ?/sec    1.00   1601.2±6.72ns        ? ?/sec
   cast int32 to float32 512                                          1.00    168.0±0.60ns        ? ?/sec    1.02    171.4±3.81ns        ? ?/sec
   cast int32 to float64 512                                          1.00    191.5±0.60ns        ? ?/sec    1.02    194.7±3.21ns        ? ?/sec
   cast int32 to int32 512                                            1.00    163.4±1.49ns        ? ?/sec    1.00    163.7±3.62ns        ? ?/sec
   cast int32 to int64 512                                            1.00    168.6±0.49ns        ? ?/sec    1.02    172.5±3.71ns        ? ?/sec
   cast int32 to uint32 512                                           1.00    713.0±1.37ns        ? ?/sec    1.00    713.3±2.98ns        ? ?/sec
   cast int64 to decimal128(38, 10) 512                               1.01    574.9±3.35ns        ? ?/sec    1.00    571.7±3.72ns        ? ?/sec
   cast int64 to decimal32(9, -1) 512                                 1.00      3.4±0.00µs        ? ?/sec    1.00      3.4±0.00µs        ? ?/sec
   cast int64 to decimal32(9, 0) 512                                  1.01   1275.8±6.31ns        ? ?/sec    1.00   1264.7±5.90ns        ? ?/sec
   cast int64 to int32 512                                            1.00    811.2±1.53ns        ? ?/sec    1.01    822.4±3.14ns        ? ?/sec
   cast int64 within 1e6 late overflow to decimal128(18, 2) 512       1.01   1272.5±4.16ns        ? ?/sec    1.00   1264.0±6.01ns        ? ?/sec
   cast int64 within 1e6 to decimal128(18, 2) 512                     1.00    633.0±3.24ns        ? ?/sec    1.11    701.3±4.22ns        ? ?/sec
   cast micro timestamp to string                                     1.00  1202.8±12.22µs        ? ?/sec    1.00  1201.0±10.38µs        ? ?/sec
   cast micro timestamp with timezone to string                       1.01    900.8±2.33µs        ? ?/sec    1.00    894.8±2.05µs        ? ?/sec
   cast nested dict to dict                                           1.03      4.7±0.22µs        ? ?/sec    1.00      4.6±0.15µs        ? ?/sec
   cast no runs of int32s to ree<int32>                               1.03     58.5±0.83µs        ? ?/sec    1.00     56.7±0.64µs        ? ?/sec
   cast runs of 10 string to ree<int32>                               1.03      8.5±0.03µs        ? ?/sec    1.00      8.2±0.05µs        ? ?/sec
   cast runs of 1000 int32s to ree<int32>                             1.00      3.0±0.01µs        ? ?/sec    1.00      3.0±0.01µs        ? ?/sec
   cast string single run to ree<int32>                               1.00     26.8±0.02µs        ? ?/sec    1.05     28.1±0.50µs        ? ?/sec
   cast string to binary view 512                                     1.00      2.1±0.00µs        ? ?/sec    1.04      2.1±0.01µs        ? ?/sec
   cast string view to binary view                                    1.01     82.1±1.48ns        ? ?/sec    1.00     81.5±4.83ns        ? ?/sec
   cast string view to dict                                           1.00    154.9±0.30µs        ? ?/sec    1.00    154.6±0.28µs        ? ?/sec
   cast string view to string                                         1.00     43.0±0.78µs        ? ?/sec    1.00     42.9±0.94µs        ? ?/sec
   cast string view to wide string                                    1.00     42.9±0.97µs        ? ?/sec    1.00     42.8±0.81µs        ? ?/sec
   cast time32s to time32ms 512                                       1.00    812.2±0.94ns        ? ?/sec    1.00    808.3±3.15ns        ? ?/sec
   cast time32s to time64us 512                                       1.00    334.6±0.22ns        ? ?/sec    1.01    337.3±3.19ns        ? ?/sec
   cast time64 to string                                              1.01   555.4±13.46µs        ? ?/sec    1.00   551.1±11.57µs        ? ?/sec
   cast time64ns to time32s 512                                       1.00      2.3±0.00µs        ? ?/sec    1.00      2.3±0.00µs        ? ?/sec
   cast timestamp_ms to i64 512                                       1.00    251.2±2.55ns        ? ?/sec    1.01    253.8±4.11ns        ? ?/sec
   cast timestamp_ms to timestamp_ns 512                              1.00   1199.2±5.84ns        ? ?/sec    1.02   1220.1±4.80ns        ? ?/sec
   cast timestamp_ns to timestamp_s 512                               1.00    161.4±1.96ns        ? ?/sec    1.01    163.1±4.37ns        ? ?/sec
   cast utf8 to date32 512                                            1.00      7.0±0.04µs        ? ?/sec    1.00      7.0±0.05µs        ? ?/sec
   cast utf8 to date64 512                                            1.01     30.7±0.08µs        ? ?/sec    1.00     30.3±0.09µs        ? ?/sec
   cast utf8 to f32                                                   1.00      5.5±0.02µs        ? ?/sec    1.02      5.6±0.02µs        ? ?/sec
   cast utf8 to i32                                                   1.00      5.3±0.04µs        ? ?/sec    1.01      5.3±0.05µs        ? ?/sec
   cast wide string to binary view 512                                1.01      3.7±0.10µs        ? ?/sec    1.00      3.7±0.09µs        ? ?/sec
   
   ```
   
   </details>
   
   <details><summary>Per-runner information</summary>
   
   <details><summary>cast&#95;kernels — shard 1/1</summary>
   
   **Node:** gk3-benchmark-cluster-nap-wqu6m05g-a6260d63-5j8x
   
   **Instance:** c4a-highcpu-48 (12 vCPU / 65 GiB)
   
   **uname:**
   
   ```text
   Linux bench-c6004721301-3071-ckl7q 6.12.94+ #1 SMP Fri Aug 21 08:00:16 UTC 2026 aarch64 GNU/Linux
   ```
   
   **BENCH_COMMAND:**
   
   ```sh
   cargo bench --features=arrow,async,test_common,experimental,object_store --bench cast_kernels
   ```
   
   <details><summary>CPU Details (lscpu)</summary>
   
   ```text
   Architecture:                            aarch64
   CPU op-mode(s):                          64-bit
   Byte Order:                              Little Endian
   CPU(s):                                  48
   On-line CPU(s) list:                     0-47
   Vendor ID:                               ARM
   Model name:                              Neoverse-V2
   Model:                                   1
   Thread(s) per core:                      1
   Core(s) per cluster:                     48
   Socket(s):                               -
   Cluster(s):                              1
   Stepping:                                r0p1
   BogoMIPS:                                2000.00
   Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
   L1d cache:                               3 MiB (48 instances)
   L1i cache:                               3 MiB (48 instances)
   L2 cache:                                96 MiB (48 instances)
   L3 cache:                                80 MiB (1 instance)
   NUMA node(s):                            1
   NUMA node0 CPU(s):                       0-47
   Vulnerability Gather data sampling:      Not affected
   Vulnerability Indirect target selection: Not affected
   Vulnerability Itlb multihit:             Not affected
   Vulnerability L1tf:                      Not affected
   Vulnerability Mds:                       Not affected
   Vulnerability Meltdown:                  Not affected
   Vulnerability Mmio stale data:           Not affected
   Vulnerability Reg file data sampling:    Not affected
   Vulnerability Retbleed:                  Not affected
   Vulnerability Spec rstack overflow:      Not affected
   Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
   Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
   Vulnerability Spectre v2:                Mitigation; CSV2, BHB
   Vulnerability Srbds:                     Not affected
   Vulnerability Tsa:                       Not affected
   Vulnerability Tsx async abort:           Not affected
   Vulnerability Vmscape:                   Not affected
   ```
   
   </details>
   
   <details><summary>Resource Usage</summary>
   
   **base (merge-base)**
   | Metric | Value |
   |--------|-------|
   | Wall time | 780.2s |
   | Peak memory | 20.7 MiB |
   | Avg memory | 19.4 MiB |
   | CPU user | 775.7s |
   | CPU sys | 0.0s |
   | Peak spill | 0 B |
   
   **branch**
   | Metric | Value |
   |--------|-------|
   | Wall time | 790.2s |
   | Peak memory | 20.8 MiB |
   | Avg memory | 19.5 MiB |
   | CPU user | 785.9s |
   | CPU sys | 0.0s |
   | Peak spill | 0 B |
   
   
   </details>
   
   </details>
   
   </details>
   
   ---
   [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
   
   <!-- benchmark-request:6004721301:finish:28013f5cf493754c80c8f384c901e3ba -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075#issuecomment-6004721301

   run benchmark cast_kernels


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075#issuecomment-5980835066

   could we merge up to resolve the conflict


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075#issuecomment-6006947866

   see https://github.com/apache/arrow-rs/pull/11076#issuecomment-6006942555


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075#issuecomment-5953175359

   could we merge up to resolve the conflict


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075#issuecomment-6004722714

   🤖 Benchmark starting (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/11075#issuecomment-6004721301)
   
   **Target:** cast&#95;kernels
   
   **Sharding factor: 1** (1 workers).
   
   Comparing extract-temporal-cast-helpers (941682a14681cd549c353361e9261c0ab7899f3a) to 103ebe7 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/103ebe7548db35c37e8ff35fcb02438bcd182fa7..941682a14681cd549c353361e9261c0ab7899f3a)
   
   <details><summary>Run configuration</summary>
   
   ```yaml
   run benchmark cast_kernels
   shards: 1
   
   ```
   
   </details>
   
   Results will be posted when all workers finish.
   
   ---
   [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
   
   <!-- benchmark-request:6004721301:start:d45278e88243176a0a614dc0d146e6f2 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "anandghegde (via GitHub)" <gi...@apache.org>.
anandghegde commented on PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075#issuecomment-5993917258

   Merged main up again and resolved the conflicts ([941682a](https://github.com/apache/arrow-rs/commit/941682a1)). Upstream's cast refactor extracted `cast_numeric_to_binary` into the new `binary` submodule, so the PR-side copy is dropped in favor of it; the new timestamp-to-time helpers (`cast_timestamp_to_time`, `TimeType`, `timestamp_to_time`) and the rewritten `timestamp_to_date32` now live in the `temporal` submodule; and `as_time_res_with_timezone` lost its last caller in the refactor, so it is removed. `cargo test -p arrow-cast` (427 tests), clippy and fmt are clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move temporal cast helpers into a private submodule [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11075:
URL: https://github.com/apache/arrow-rs/pull/11075#issuecomment-6039735196

   Thank you @Jefffrey and @anandghegde 
   
   I do think this PR makes the code a bit better and easier to navigate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org