You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/13 13:52:41 UTC
[GitHub] [cloudstack] ravening opened a new pull request #3805: UI: Display
drop down list for VPN customer gateway selection
ravening opened a new pull request #3805: UI: Display drop down list for VPN customer gateway selection
URL: https://github.com/apache/cloudstack/pull/3805
## Description
<!--- Describe your changes in detail -->
Display drop-down list for VPN customer gateway selection in UI so that it can be searched according to domains
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
Before the change, there was no drop down list for domains
After the change there is a drop down and the domains are displayed in the sorted order
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3805: UI: Display
drop down list for VPN customer gateway selection
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3805: UI: Display drop down list for VPN customer gateway selection
URL: https://github.com/apache/cloudstack/pull/3805#issuecomment-580191894
> > @ravening I see your use case and do approve. Could you please keep in mind that this UI is phased out and create a primate ticket?
>
> @DaanHoogland Just to confirm, are you saying all the future Ui pr's should be raised again primate and not here?
No, not at the moment. I am saying that primate is planned to replace the UI as the standard UI in 4.15. It is still in alpha mode so it may take a while. but when voted on primate will probably be the only UI maintained and whether it will be part of this project is to be decided but very likely, so in that case PRs for UI will still be here!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3805: UI: Display
drop down list for VPN customer gateway selection
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3805: UI: Display drop down list for VPN customer gateway selection
URL: https://github.com/apache/cloudstack/pull/3805#issuecomment-580669603
> Can anyone confirm manual testing?
I have manually tested it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3805: UI: Display drop down
list for VPN customer gateway selection
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3805: UI: Display drop down list for VPN customer gateway selection
URL: https://github.com/apache/cloudstack/pull/3805#issuecomment-583242987
Merging this based on @weizhouapache 's manual tests, code lgtm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3805: UI: Display drop down
list for VPN customer gateway selection
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3805: UI: Display drop down list for VPN customer gateway selection
URL: https://github.com/apache/cloudstack/pull/3805#issuecomment-580668986
Can anyone confirm manual testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3805: UI: Display
drop down list for VPN customer gateway selection
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3805: UI: Display drop down list for VPN customer gateway selection
URL: https://github.com/apache/cloudstack/pull/3805#issuecomment-580148976
pure UI change.
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ravening commented on issue #3805: UI: Display drop
down list for VPN customer gateway selection
Posted by GitBox <gi...@apache.org>.
ravening commented on issue #3805: UI: Display drop down list for VPN customer gateway selection
URL: https://github.com/apache/cloudstack/pull/3805#issuecomment-580176152
> @ravening I see your use case and do approve. Could you please keep in mind that this UI is phased out and create a primate ticket?
@DaanHoogland Just to confirm, are you saying all the future Ui pr's should be raised again primate and not here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3805: UI: Display drop down
list for VPN customer gateway selection
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3805: UI: Display drop down list for VPN customer gateway selection
URL: https://github.com/apache/cloudstack/pull/3805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3805: UI: Display
drop down list for VPN customer gateway selection
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3805: UI: Display drop down list for VPN customer gateway selection
URL: https://github.com/apache/cloudstack/pull/3805#issuecomment-580168914
@ravening I see your use case and do approve. Could you please keep in mind that this UI is phased out and create a primate ticket?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services