You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/26 16:52:20 UTC
[GitHub] [arrow] wjones127 commented on a diff in pull request #14235: ARROW-17692 [R]: Arrow Package Installation: undefined symbol error
wjones127 commented on code in PR #14235:
URL: https://github.com/apache/arrow/pull/14235#discussion_r980289695
##########
r/configure:
##########
@@ -255,8 +255,8 @@ if [ $? -eq 0 ]; then
if arrow_built_with ARROW_S3; then
PKG_CFLAGS="$PKG_CFLAGS -DARROW_R_WITH_S3"
if [ "$BUNDLED_LIBS" != "" ]; then
- # We're depending on openssl/curl from the system, so they're not in the bundled deps
- BUNDLED_LIBS="$BUNDLED_LIBS -lssl -lcrypto -lcurl"
+ # We're depending on openssl/curl/AWS SDK from the system, so they're not in the bundled deps
+ BUNDLED_LIBS="$BUNDLED_LIBS -lssl -lcrypto -lcurl -laws-cpp-sdk-identity-management -laws-cpp-sdk-sts -laws-cpp-sdk-cognito-identity -laws-cpp-sdk-s3 -laws-cpp-sdk-core -laws-c-event-stream -laws-checksums -laws-c-common"
Review Comment:
This seems fine, but I honestly am very confused what `BUNDLED_LIBS` is supposed to represent (or, why aren't we just adding them to `PKG_LIBS`?). Maybe it's that these are the dependencies of what is in the bundled libraries, so they need to *after* when linking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org