You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Martin Bektchiev <Ma...@telerik.com> on 2014/02/27 08:38:57 UTC

CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

Hi guys,

I have prepared a pull request for fixing the above-mentioned issue. Can you please review it at https://github.com/apache/cordova-plugman/pull/54?

Thanks in advance!

Martin

Re: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

Posted by Andrew Grieve <ag...@chromium.org>.
My sentiment is the same. This is a good improvement (current behaviour is
to loop forever). If someone's so inclined, there's no reason we couldn't
support circular deps.


On Fri, Feb 28, 2014 at 10:43 AM, Jonathan Bond-Caron <
jbondc@gdesolutions.com> wrote:

> On Fri Feb 28 10:18 AM, Martin Bektchiev wrote:
> > My first idea was to allow the installation of such interdependent
> plugins, but
> > then I saw that once added they cannot be uninstalled due to the cylce
> in the
> > graph. That's why I decided to stay consistent with uninstall and not
> allow it.
> >
>
> Gotcha, I guess it works for now.  Eventually I'd like to get rid of
> dep-graph and store the deps tree in json.
>
>
>

RE: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

Posted by Jonathan Bond-Caron <jb...@gdesolutions.com>.
On Fri Feb 28 10:18 AM, Martin Bektchiev wrote:
> My first idea was to allow the installation of such interdependent plugins, but
> then I saw that once added they cannot be uninstalled due to the cylce in the
> graph. That's why I decided to stay consistent with uninstall and not allow it.
> 

Gotcha, I guess it works for now.  Eventually I'd like to get rid of dep-graph and store the deps tree in json.



RE: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

Posted by Martin Bektchiev <Ma...@telerik.com>.
My first idea was to allow the installation of such interdependent plugins, but then I saw that once added they cannot be uninstalled due to the cylce in the graph. That's why I decided to stay consistent with uninstall and not allow it. 

Besides what is the point in having such interdependent plugins? I suppose that you'd simply want to merge them into one.

-----Original Message-----
From: Jonathan Bond-Caron [mailto:jbondc@gdesolutions.com] 
Sent: Friday, February 28, 2014 16:01
To: dev@cordova.apache.org
Subject: RE: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

On Fri Feb 28 08:09 AM, Andrew Grieve wrote:
> Thanks Martin! Looks good! I've merged it in :)
> 
> 

Should just keep track of what's pending to be installed, why throw an exception?


RE: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

Posted by Jonathan Bond-Caron <jb...@gdesolutions.com>.
On Fri Feb 28 08:09 AM, Andrew Grieve wrote:
> Thanks Martin! Looks good! I've merged it in :)
> 
> 

Should just keep track of what's pending to be installed, why throw an exception?


Re: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

Posted by Andrew Grieve <ag...@chromium.org>.
Also - I've given you JIRA access so that you can assign issues to yourself
:)


On Fri, Feb 28, 2014 at 8:09 AM, Andrew Grieve <ag...@chromium.org> wrote:

> Thanks Martin! Looks good! I've merged it in :)
>
>
> On Thu, Feb 27, 2014 at 2:38 AM, Martin Bektchiev <
> Martin.Bektchiev@telerik.com> wrote:
>
>> Hi guys,
>>
>> I have prepared a pull request for fixing the above-mentioned issue. Can
>> you please review it at https://github.com/apache/cordova-plugman/pull/54
>> ?
>>
>> Thanks in advance!
>>
>> Martin
>>
>
>

Re: CB-6028: Fix for infinte loop in plugman with plugins with cyclic dependencies

Posted by Andrew Grieve <ag...@chromium.org>.
Thanks Martin! Looks good! I've merged it in :)


On Thu, Feb 27, 2014 at 2:38 AM, Martin Bektchiev <
Martin.Bektchiev@telerik.com> wrote:

> Hi guys,
>
> I have prepared a pull request for fixing the above-mentioned issue. Can
> you please review it at https://github.com/apache/cordova-plugman/pull/54?
>
> Thanks in advance!
>
> Martin
>