[GitHub] [arrow] westonpace commented on a diff in pull request #34616: GH-29238 [C++][Dataset][Parquet] Support parquet modular encryption in the new Dataset API

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1169125808


##########
cpp/src/arrow/dataset/file_parquet.h:
##########
@@ -136,6 +138,33 @@ class ARROW_DS_EXPORT ParquetFileFormat : public FileFormat {
       fs::FileLocator destination_locator) const override;
 
   std::shared_ptr<FileWriteOptions> DefaultWriteOptions() override;
+   
+  /// \brief A getter function to retrieve the dataset encryption configuration
+  std::shared_ptr<parquet::encryption::DatasetEncryptionConfiguration> GetDatasetEncryptionConfig() const {
+    return dataset_encryption_config_;
+  }
+  /// \brief A getter function to retrieve the dataset decryption configuration
+  std::shared_ptr<parquet::encryption::DatasetDecryptionConfiguration> GetDatasetDecryptionConfig() const {
+    return dataset_decryption_config_;
+  }

Review Comment:
   I wouldn't want to add new pyarrow properties as part of the 12.0.0 release that we then have to do a deprecation cycle for.  However, it seems like the user-facing python API wouldn't have to change if we changed this internally.  If you agree then I think this can be a follow-up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org