[jira] [Resolved] (MAPREDUCE-1166) SerialUtils.cc: dynamic allocation of arrays based on runtime variable is not portable

["Allen Wittenauer (Resolved) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAPREDUCE-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer resolved MAPREDUCE-1166.
-----------------------------------------

    Resolution: Won't Fix

Hadoop's focus is not on portability.  Closing as won't fix.
                
> SerialUtils.cc: dynamic allocation of arrays based on runtime variable is not portable
> --------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1166
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1166
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: MAPREREDUCE-1166.patch
>
>
> In SerialUtils.cc, the following code appears:
>     int len;
>     if (b < -120) {
>       negative = true;
>       len = -120 - b;
>     } else {
>       negative = false;
>       len = -112 - b;
>     }
>     uint8_t barr[len];
> as far as I'm aware, this is not legal in ANSI C and will be rejected by ANSI compliant compilers.  Instead, this should be malloc()'d based upon the size of len and free()'d later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira