[jira] [Commented] (TS-4189) Add more tests for HPACK

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307482#comment-15307482 ] 

ASF GitHub Bot commented on TS-4189:
------------------------------------

GitHub user maskit opened a pull request:

    https://github.com/apache/trafficserver/pull/677

    TS-4189: Add tests for HPACK

    https://issues.apache.org/jira/browse/TS-4189
    
    The test cases come from:
    https://github.com/http2jp/hpack-test-case
    https://github.com/http2/http_samples
    
    But the original data are not included in these commits because we can use our own test results as input data.
    
    Of course, we can add more tests locally.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maskit/trafficserver ts4189

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #677
    
----
commit 16184644a05c19361f3a944a5932d6e31aca64fc
Author: Masakazu Kitajo <ma...@apache.org>
Date:   2016-04-01T01:13:58Z

    TS-4189: Add a test driver for HPACK

commit c8ad9cf57677b4fe53ce1789bed9e123c01b3b9b
Author: Masakazu Kitajo <ma...@apache.org>
Date:   2016-05-31T08:12:32Z

    TS-4189: Add test cases for test_HPACK

----


> Add more tests for HPACK
> ------------------------
>
>                 Key: TS-4189
>                 URL: https://issues.apache.org/jira/browse/TS-4189
>             Project: Traffic Server
>          Issue Type: Test
>          Components: HTTP/2, Tests
>            Reporter: Masakazu Kitajo
>             Fix For: 7.0.0
>
>
> We should add practical test data for testing HPACK module to check its efficiency and performance. It would be better to add before any changes related to HPACK.
> I think hpack-test-case is a suitable one. It's a set of sample requests and responses which is originally contributed to the IETF working group.
> https://github.com/http2jp/hpack-test-case
> Several HPACK implementations use this sample for tests and checking compatibility. Using the same sample is also helpful when we compare performance and efficiency between ours and others.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)