[jira] [Created] (VFS-581) FTPClientWrapper hides important error information

["L (JIRA)" <ji...@apache.org>]

L created VFS-581:
---------------------

             Summary: FTPClientWrapper hides important error information
                 Key: VFS-581
                 URL: https://issues.apache.org/jira/browse/VFS-581
             Project: Commons VFS
          Issue Type: Bug
    Affects Versions: Nightly Builds, 2.1
            Reporter: L


One place where FTPClientWrapper hides errors is method listFilesInDirectory().

1. Lines 163-167: After performing getFtpClient().listFiles(relPath); the code checks for a positive FTP reply. 

2. If the reply was negative, the code assumes the negative reply has to do with VFS-307 as stated in the comments. This is not always the case, there might be other reasons why the operation might have failed. In my case it was an FTPS connection where the server required an encrypted data channel and the client did was not properly configured.

3. Line 182: getFtpClient().listFiles();. This time without even looking at the FTP reply string. In my case it was the same error as above. As a result my client got an empty as if the remote directory did not have any files, while the real error reason was nowhere to see.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)