[GitHub] ivankelly commented on a change in pull request #817: Client times out requests in batch rather than individually

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #817: Client times out requests in batch rather than individually
URL: https://github.com/apache/bookkeeper/pull/817#discussion_r156038117
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 ##########
 @@ -1641,19 +1656,29 @@ void reset(final CompletionKey key,
             this.ledgerId = ledgerId;
             this.entryId = entryId;
             this.startTime = MathUtils.nowInNano();
-            this.timeout = scheduleTimeout(key, addEntryTimeout);
         }
 
         @Override
         public void writeComplete(int rc, long ledgerId, long entryId,
                                   BookieSocketAddress addr,
                                   Object ctx) {
-            cancelTimeoutAndLogOp(rc);
+            logOpResult(rc);
             originalCallback.writeComplete(rc, ledgerId, entryId, addr, ctx);
             key.release();
             handle.recycle(this);
         }
 
+        @Override
+        boolean maybeTimeout() {
+            LOG.info("maybeTimeout");
 
 Review comment:
   @zhaijack Yes, but lets hold off until all the yahoo changes are in. Changes like that can cause a lot of churn and make merges a pain.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services