You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/24 14:06:40 UTC

[GitHub] [flink] rmetzger commented on a diff in pull request #21344: [FLINK-30083] Bump maven-shade-plugin version

rmetzger commented on code in PR #21344:
URL: https://github.com/apache/flink/pull/21344#discussion_r1031550455


##########
pom.xml:
##########
@@ -991,7 +991,7 @@ under the License.
 						<plugin>
 							<groupId>org.apache.maven.plugins</groupId>
 							<artifactId>maven-shade-plugin</artifactId>
-							<version>3.2.4</version>
+							<version>3.4.0</version>

Review Comment:
   a) no real reason. I thought it would be safer to update to the minimum required version.... but using the latest bugfix version should actually be even safer.
   b) I didn't check the surroundings enough. Just looked for maven-shade-plugin and changed the version 🙈 
   
   Great that this fixes more issues. Let's hope it works (my previous change was a no-op for our CI I guess ;) ) and it doesn't introduce other issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org