You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "317brian (via GitHub)" <gi...@apache.org> on 2024/01/25 22:57:24 UTC
[PR] docs: clean up some rolling updates stuff (druid)
317brian opened a new pull request, #15762:
URL: https://github.com/apache/druid/pull/15762
Cleans up some old stuff in the rolling updates doc as well as clarifies the upgrade order a little.
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: clean up some rolling updates stuff (druid)
Posted by "317brian (via GitHub)" <gi...@apache.org>.
317brian commented on code in PR #15762:
URL: https://github.com/apache/druid/pull/15762#discussion_r1468113077
##########
docs/operations/rolling-updates.md:
##########
@@ -27,15 +27,15 @@ For rolling Apache Druid cluster updates with no downtime, we recommend updating
following order:
1. Historical
-2. \*Overlord (if any)
-3. \*Middle Manager/Indexers (if any)
-4. Standalone Real-time (if any)
-5. Broker
+2. Middle Manager and Indexers (if any)
+3. Broker
+4. Routers
+5. Overlord (Note that you can upgrade the Overlord before any MiddleManager processes if you use [autoscaling-based replacement](#autoscaling-based-replacement).)
Review Comment:
Singular since the intro sentence uses "processes"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: clean up some rolling updates stuff (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on code in PR #15762:
URL: https://github.com/apache/druid/pull/15762#discussion_r1468104380
##########
docs/operations/rolling-updates.md:
##########
@@ -27,15 +27,15 @@ For rolling Apache Druid cluster updates with no downtime, we recommend updating
following order:
1. Historical
Review Comment:
```suggestion
1. Historicals
```
##########
docs/operations/rolling-updates.md:
##########
@@ -27,15 +27,15 @@ For rolling Apache Druid cluster updates with no downtime, we recommend updating
following order:
1. Historical
-2. \*Overlord (if any)
-3. \*Middle Manager/Indexers (if any)
-4. Standalone Real-time (if any)
-5. Broker
+2. Middle Manager and Indexers (if any)
+3. Broker
+4. Routers
+5. Overlord (Note that you can upgrade the Overlord before any MiddleManager processes if you use [autoscaling-based replacement](#autoscaling-based-replacement).)
Review Comment:
Not sure which one reads better (singular/plural form consistency):
```suggestion
3. Brokers
4. Routers
5. Overlords (Note that you can upgrade the Overlords before any MiddleManagers if you use [autoscaling-based replacement](#autoscaling-based-replacement).)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: clean up some rolling updates stuff (druid)
Posted by "317brian (via GitHub)" <gi...@apache.org>.
317brian merged PR #15762:
URL: https://github.com/apache/druid/pull/15762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org