You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ochalover (via GitHub)" <gi...@apache.org> on 2025/01/16 06:18:17 UTC
[I] [Bigquery] Table name is not showing up from custom role [superset]
ochalover opened a new issue, #31882:
URL: https://github.com/apache/superset/issues/31882
### Bug description
I built the custom image from superset repo. The steps that I followed
1. Create a dummy user
2. Create a custom role to give access to only a single table under dataset and assign this new role to dummy user
3. Try logging in with dummy user. You can see dataset under the sqllab screen but not able to see table name there. PFA attached screenshot
4. if you run query from sqllab screen, it works for that particular table.
### Screenshots/recordings
_No response_
### Superset version
master / latest-dev
### Python version
3.11
### Node version
16
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "ts-saurabhkdm (via GitHub)" <gi...@apache.org>.
ts-saurabhkdm commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3194733433
@rusackas As @Hen0k mentioned. This is the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "codenamelxl (via GitHub)" <gi...@apache.org>.
codenamelxl commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3138423020
> [@codenamelxl](https://github.com/codenamelxl) This does not fix mentioned issue. Issue is more like let's assume I have 10 table, I created role for 1 table when I applied role like that to non-admin user who has access to only sqllab. It can not see tableschema but with your mentioned permission it just give access to all 10 tables which is bad idea for us. This feature was working till V4.1
Could you check whether you also grant `database access on ...` or `schema access on ...` to that user?
The MR only grant permissison for `sql_lab` to see the table schema, it does not control what table the user can see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "ts-saurabhkdm (via GitHub)" <gi...@apache.org>.
ts-saurabhkdm commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3138526248
problem here is cosmetic. End users can query tables but tables are not popping in the list. It always list empty table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-4725627715
#32340 merged a while back to grant TableSchemaView to the sql_lab role. @ts-saurabhkdm have you retested on current master (after re-running superset init)? If the table list is still empty, can you share the exact perms on the custom role? @Hen0k feel free to see if this is still an issue in 6.x, if you're able to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "Hen0k (via GitHub)" <gi...@apache.org>.
Hen0k commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3566973171
Hey @betodealmeida
Any updates on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "Hen0k (via GitHub)" <gi...@apache.org>.
Hen0k commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-4943768438
@rusackas I am now using 6.0.0, and this is resolved. It works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "ts-saurabhkdm (via GitHub)" <gi...@apache.org>.
ts-saurabhkdm commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-2856869173
I can test that branch to see if it solves the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-4950224693
Awesome, thanks for confirmation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "codenamelxl (via GitHub)" <gi...@apache.org>.
codenamelxl commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3138536963
> problem here is cosmetic. End users can query tables but tables are not popping in the list. It always list empty table.
Somewhat `cosmetic` . #32340 fix this issue. Your issue with user can see all table schema is a different topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "Hen0k (via GitHub)" <gi...@apache.org>.
Hen0k commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3245116482
@rusackas , @betodealmeida I started testing this from 3.0.0 upto 4.1.0 and 4.1.0 is where this feature stops working. I made sure to drop the metadata schema that superset was using to start from a clean metadata database.
I think it is related to the removal of sl_tables or something related. The API call from the frontend is consistent, but on 4.1.0 the response it gets is an empty list. I saw a few merges related to changes on the semantic layer of dataset handling.
I hope this helps move things faster. I am stuck in a situation where I either give my users permission to an entire schema or downgrade to 4.0.0. And I am not even sure downgrading will work without metadata loss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-2594634697
<!-- Answer -->
I found a similar closed issue titled "SqlLab preview permissions error" on the Superset GitHub repository. However, no solution was found in the comments of that issue <sup>[[1]](https://github.com/apache/superset/issues/20511)</sup>. You might want to check if there are any updates or additional comments that could be relevant to your situation.
<!-- Dosu Comment Footer -->
*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
---
<sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/18638915-f424-4ce5-a11d-77651765d1b8?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/18638915-f424-4ce5-a11d-77651765d1b8?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/18638915-f424-4ce5-a11d-77651765d1b8?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/18638915-f424-4ce5-a11d-77651765d1b8?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/18638915-f424-4ce5-a11d-77651765d1b8?feedback_type=hallucination) | [Other](https://app.dosu.dev/response-feedback/18638915-f424-4ce5-a11d-77651765d1b8?feedback_type=other)</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "codenamelxl (via GitHub)" <gi...@apache.org>.
codenamelxl commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3034425598
You can check whether your SQLLab contains these permission
```
can post on TableSchemaView
can delete on TableschemaView
can expaned on TableschemaView
```
If you applied the above PR after your DB was inited. You need to run `superset init` again to give SQLLab role the extra permissions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "ts-saurabhkdm (via GitHub)" <gi...@apache.org>.
ts-saurabhkdm commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-2928687329
@rusackas This above fix/PR does not solves the existing issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "ts-saurabhkdm (via GitHub)" <gi...@apache.org>.
ts-saurabhkdm commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3138304116
@codenamelxl This does not fix mentioned issue. Issue is more like let's assume i have 10 table, I created role for 1 table when I applied role like that to non-admin user who has access to only sqllab, it can not see tableschema but with your mentioned permission it just give access to all 10 tables which is bad idea for us. This one feature was workingt till V4.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "codenamelxl (via GitHub)" <gi...@apache.org>.
codenamelxl commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3138662171
> Thank you for fixing this issue. I am sorry but description clearly mentions my issue. Tagging different issue with this issue here is wrong. This feature got lost in past upgrades. I remember this was working correctly in 3.X version. You are correct about if I gave access to whole dataset in bigquery then users can see schema for whole thing but we want to give granular access to the tables here.
AFAIK, there is no table level control on this part of SQL_Lab. It's only up until schema(database) level. If you want to enforce table level control, you will have to do it on your underlying Datasource (not superset).
Or you can try creating a Dataset and control from there. But I rmb vague that it does not apply to SQL Lab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #31882: [Bigquery] Table name is not showing up from custom role
URL: https://github.com/apache/superset/issues/31882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "ts-saurabhkdm (via GitHub)" <gi...@apache.org>.
ts-saurabhkdm commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3138593479
> > problem here is cosmetic. End users can query tables but tables are not popping in the list. It always list empty table.
>
> Somewhat `cosmetic` . [#32340](https://github.com/apache/superset/pull/32340) fix this issue. Your issue with user can see all table schema is a different topic.
Thank you for fixing this issue. I am sorry but description clearly mentions my issue. Tagging different issue with this issue here is wrong. This feature got lost in past upgrades. I remember this was working correctly in 3.X version. You are correct about if I gave access to whole dataset in bigquery then users can see schema for whole thing but we want to give granular access to the tables here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "Hen0k (via GitHub)" <gi...@apache.org>.
Hen0k commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3191414386
I am also facing this issue in Postgres. It was working with 4.1.2. After moving to 5.0.0 it stopped working. I was controlling the access using superset roles and creating datasets with the tables. These roles allow me to give granular permission to the data. And I don't want to give access to an entire schema or the whole database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-2855458483
Wondering if [this](https://github.com/apache/superset/pull/32340) might solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] [Bigquery] Table name is not showing up from custom role [superset]
Posted by "Hen0k (via GitHub)" <gi...@apache.org>.
Hen0k commented on issue #31882:
URL: https://github.com/apache/superset/issues/31882#issuecomment-3299598006
@rusackas @michael-s-molina Could [this](https://github.com/apache/superset/pull/27772) PR have had something to do with this issue?
And a small update on when the feature stops. I was able to confirm it working on 4.0.2 and it stops working on 4.1.0
Any feedback is much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org