You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/02/18 03:11:50 UTC
Review Request 31144: Renaming OfferQueue into OfferManager.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31144/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
Description
-------
Renaming OfferQueue into OfferManager to better reflect its meaning.
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/Offers.java 55bc2f7eeaae6d3ed6daaa1112460a9851579bc5
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 8c11ef8bd6609f3e4d97ca154d922898f8362446
src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 80f1d83fd32fe1a2313856dc50ff8c8a69221b99
src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 7f2c7605ad6e676dec3384913f23945e795dcb9e
src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 332338b7bef7d622333f8ea6508c4f5970b8e7c4
src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 2accb4e1051638fb16ca0411ccc6985e4dbb3b65
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java ced3bdef1731354aedc82bb12f45ba6f040e1ab7
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 6e89075db3c2500a9546d9fbeefca717a3eb3f4c
src/main/java/org/apache/aurora/scheduler/http/Offers.java 6d75c3ae4693c62cb678dae9cc914e8d65295265
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java bde45db33527118f5d53ad4ea9f71ddb6f84eee9
src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java f96110c55011699768f17cc2d4afdc8bf7daa16c
src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 2b5dc4902f57e508d76f5e16997ae09d04464220
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 7963e473b83a04e29f70360833fc6e553646fc4c
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 74e31334bc139c47eb8b0beee46ee7bad62a2f80
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 4c2448ffba5c7e0f0ea59fc6484fbcdfc7df7f52
src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 652d2477e0fd69d9f9f4d46a150145ad062cf5d2
Diff: https://reviews.apache.org/r/31144/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 31144: Renaming OfferQueue into OfferManager.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31144/#review72879
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Feb. 17, 2015, 6:11 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31144/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 6:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Renaming OfferQueue into OfferManager to better reflect its meaning.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java 55bc2f7eeaae6d3ed6daaa1112460a9851579bc5
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 8c11ef8bd6609f3e4d97ca154d922898f8362446
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 80f1d83fd32fe1a2313856dc50ff8c8a69221b99
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 7f2c7605ad6e676dec3384913f23945e795dcb9e
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 332338b7bef7d622333f8ea6508c4f5970b8e7c4
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 2accb4e1051638fb16ca0411ccc6985e4dbb3b65
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java ced3bdef1731354aedc82bb12f45ba6f040e1ab7
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 6e89075db3c2500a9546d9fbeefca717a3eb3f4c
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 6d75c3ae4693c62cb678dae9cc914e8d65295265
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java bde45db33527118f5d53ad4ea9f71ddb6f84eee9
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java f96110c55011699768f17cc2d4afdc8bf7daa16c
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 2b5dc4902f57e508d76f5e16997ae09d04464220
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 7963e473b83a04e29f70360833fc6e553646fc4c
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 74e31334bc139c47eb8b0beee46ee7bad62a2f80
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 4c2448ffba5c7e0f0ea59fc6484fbcdfc7df7f52
> src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 652d2477e0fd69d9f9f4d46a150145ad062cf5d2
>
> Diff: https://reviews.apache.org/r/31144/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31144: Renaming OfferQueue into OfferManager.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31144/#review72883
-----------------------------------------------------------
Master (ec66a5e) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.kill_manager ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... FAILURE
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 18, 2015, 2:11 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31144/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 2:11 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Renaming OfferQueue into OfferManager to better reflect its meaning.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java 55bc2f7eeaae6d3ed6daaa1112460a9851579bc5
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 8c11ef8bd6609f3e4d97ca154d922898f8362446
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 80f1d83fd32fe1a2313856dc50ff8c8a69221b99
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 7f2c7605ad6e676dec3384913f23945e795dcb9e
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 332338b7bef7d622333f8ea6508c4f5970b8e7c4
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 2accb4e1051638fb16ca0411ccc6985e4dbb3b65
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java ced3bdef1731354aedc82bb12f45ba6f040e1ab7
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 6e89075db3c2500a9546d9fbeefca717a3eb3f4c
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 6d75c3ae4693c62cb678dae9cc914e8d65295265
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java bde45db33527118f5d53ad4ea9f71ddb6f84eee9
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java f96110c55011699768f17cc2d4afdc8bf7daa16c
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 2b5dc4902f57e508d76f5e16997ae09d04464220
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 7963e473b83a04e29f70360833fc6e553646fc4c
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 74e31334bc139c47eb8b0beee46ee7bad62a2f80
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 4c2448ffba5c7e0f0ea59fc6484fbcdfc7df7f52
> src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 652d2477e0fd69d9f9f4d46a150145ad062cf5d2
>
> Diff: https://reviews.apache.org/r/31144/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31144: Renaming OfferQueue into OfferManager.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31144/#review72881
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Feb. 18, 2015, 2:11 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31144/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 2:11 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Renaming OfferQueue into OfferManager to better reflect its meaning.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java 55bc2f7eeaae6d3ed6daaa1112460a9851579bc5
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 8c11ef8bd6609f3e4d97ca154d922898f8362446
> src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 80f1d83fd32fe1a2313856dc50ff8c8a69221b99
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 7f2c7605ad6e676dec3384913f23945e795dcb9e
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 332338b7bef7d622333f8ea6508c4f5970b8e7c4
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 2accb4e1051638fb16ca0411ccc6985e4dbb3b65
> src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java ced3bdef1731354aedc82bb12f45ba6f040e1ab7
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 6e89075db3c2500a9546d9fbeefca717a3eb3f4c
> src/main/java/org/apache/aurora/scheduler/http/Offers.java 6d75c3ae4693c62cb678dae9cc914e8d65295265
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java bde45db33527118f5d53ad4ea9f71ddb6f84eee9
> src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java f96110c55011699768f17cc2d4afdc8bf7daa16c
> src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 2b5dc4902f57e508d76f5e16997ae09d04464220
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 7963e473b83a04e29f70360833fc6e553646fc4c
> src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 74e31334bc139c47eb8b0beee46ee7bad62a2f80
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 4c2448ffba5c7e0f0ea59fc6484fbcdfc7df7f52
> src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 652d2477e0fd69d9f9f4d46a150145ad062cf5d2
>
> Diff: https://reviews.apache.org/r/31144/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>