You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/23 10:58:00 UTC
[jira] [Commented] (IGNITE-9051) Remove unnecessary ssh tests

    [ https://issues.apache.org/jira/browse/IGNITE-9051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552658#comment-16552658 ] 

ASF GitHub Bot commented on IGNITE-9051:
----------------------------------------

GitHub user 1vanan opened a pull request:

    https://github.com/apache/ignite/pull/4404

    IGNITE-9051 'Remove unnecessary ssh tests'

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1vanan/ignite IGNITE-9051

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4404
    
----
commit 6e971c0b26f41c59ff534d1c1b5a95543fd39f3e
Author: Fedotov <va...@...>
Date:   2018-07-23T10:55:49Z

    remove unnecessary tests

----


> Remove unnecessary ssh tests
> ----------------------------
>
>                 Key: IGNITE-9051
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9051
>             Project: Ignite
>          Issue Type: Test
>            Reporter: Ivan Fedotov
>            Assignee: Ivan Fedotov
>            Priority: Major
>
> Now in IgniteProjectionStartStopRestartSelfTest there are two unnecessary tests [1], [2] that duplicate other tests. Its duplicate testStopNodesByIds and testRestartNodesByIds respectively because order of ids is not important: if we go deeper in ignite.cluster().stopNodes() method, we can see that in ClusterIgniteImpl [3] all nodes id will be collected in HashSet in forNodesIds method [4]. 
> So testStopNodesByIdsC and testRestartNodesByIdsC should be removed.
> [1][https://github.com/apache/ignite/blob/master/modules/ssh/src/test/java/org/apache/ignite/internal/IgniteProjectionStartStopRestartSelfTest.java#L701]
> [2][https://github.com/apache/ignite/blob/master/modules/ssh/src/test/java/org/apache/ignite/internal/IgniteProjectionStartStopRestartSelfTest.java#L917]
> [3][https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterImpl.java#L250]
> [4][https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java#L454]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)