You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/11 14:29:56 UTC
[GitHub] [beam] johnjcasey opened a new pull request, #22688: Attempt to fix SpannerIO test flakes
johnjcasey opened a new pull request, #22688:
URL: https://github.com/apache/beam/pull/22688
We are seeing spanner test failures due to timeouts: https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1/1963/testReport/junit/org.apache.beam.sdk.io.gcp.spanner/SpannerWriteIT/testReportFailures/
After investigation, it appears that the issue is due to a JVM deadlock when trying to deserialize the dialect class: ```com.google.cloud.spanner.Dialect.(Dialect.java:37)
java.lang.Class.forName0(Native Method)
java.lang.Class.forName(Class.java:264) org.apache.beam.runners.dataflow.util.SerializableCoderCloudObjectTranslator.fromCloudObject(SerializableCoderCloudObjectTranslator.java:45)
org.apache.beam.runners.dataflow.util.SerializableCoderCloudObjectTranslator.fromCloudObject(SerializableCoderCloudObjectTranslator.java:27)
org.apache.beam.runners.dataflow.util.CloudObjects.coderFromCloudObject(CloudObjects.java:128)```
After consultation, we think the issue is similar to https://bugs.openjdk.org/browse/JDK-8072592
As such, this change is to prevent initialization of the class, and to ensure we are using the thread local class loader to prevent collisions
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nielm commented on pull request #22688: Attempt to fix SpannerIO test flakes
Posted by GitBox <gi...@apache.org>.
nielm commented on PR #22688:
URL: https://github.com/apache/beam/pull/22688#issuecomment-1214160253
Lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22688: Attempt to fix SpannerIO test flakes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22688:
URL: https://github.com/apache/beam/pull/22688#issuecomment-1213409323
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @apilloud for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #22688: Attempt to fix SpannerIO test flakes
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #22688:
URL: https://github.com/apache/beam/pull/22688#issuecomment-1212307275
run java postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey merged pull request #22688: Attempt to fix SpannerIO test flakes
Posted by GitBox <gi...@apache.org>.
johnjcasey merged PR #22688:
URL: https://github.com/apache/beam/pull/22688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #22688: Attempt to fix SpannerIO test flakes
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #22688:
URL: https://github.com/apache/beam/pull/22688#issuecomment-1212068275
@nielm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #22688: Attempt to fix SpannerIO test flakes
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #22688:
URL: https://github.com/apache/beam/pull/22688#issuecomment-1212345566
@kennknowles this is a potential fix for the jvm deadlock I mentioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org