You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/05/19 14:20:31 UTC

[GitHub] [incubator-apisix] ShiningRush opened a new pull request #1599: Fix/batch-requests-cookie

ShiningRush opened a new pull request #1599:
URL: https://github.com/apache/incubator-apisix/pull/1599


   ### Summary
   
   - default copy cookie to every request
   - add headers parameter to admin test function
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] moonming commented on pull request #1599: Fix/batch-requests-cookie

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1599:
URL: https://github.com/apache/incubator-apisix/pull/1599#issuecomment-634551620


   I restart travis CI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis commented on a change in pull request #1599: Fix/batch-requests-cookie

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1599:
URL: https://github.com/apache/incubator-apisix/pull/1599#discussion_r429953774



##########
File path: t/plugin/batch-requests.t
##########
@@ -684,3 +684,84 @@ GET /aggregate
 passed
 --- no_error_log
 [error]
+
+
+
+=== TEST 15: copy cookie to every rquest

Review comment:
       `rquest` typo




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] ShiningRush commented on pull request #1599: Fix/batch-requests-cookie

Posted by GitBox <gi...@apache.org>.
ShiningRush commented on pull request #1599:
URL: https://github.com/apache/incubator-apisix/pull/1599#issuecomment-634483854


   @membphis the error of travis is not related with this commit, please check it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix] membphis merged pull request #1599: Fix/batch-requests-cookie

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1599:
URL: https://github.com/apache/incubator-apisix/pull/1599


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org