You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/02/09 18:04:14 UTC

[GitHub] [brooklyn-server] duncangrant opened a new pull request #1147: Pass newly created streams to winrm

duncangrant opened a new pull request #1147:
URL: https://github.com/apache/brooklyn-server/pull/1147


   Extra streams are created to handle the different windows powershell streams but these were not being passed to winrm.  This fixes that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [brooklyn-server] asfgit merged pull request #1147: Pass newly created streams to winrm

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1147:
URL: https://github.com/apache/brooklyn-server/pull/1147


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1147: Pass newly created streams to winrm

Posted by GitBox <gi...@apache.org>.
ahgittin commented on a change in pull request #1147:
URL: https://github.com/apache/brooklyn-server/pull/1147#discussion_r573565336



##########
File path: core/src/main/java/org/apache/brooklyn/util/core/task/system/ProcessTaskWrapper.java
##########
@@ -49,10 +47,9 @@
     private final Task<RET> task;
 
     // execution details
-    private ByteArrayOutputStream stdout;
-    private ByteArrayOutputStream stderr;

Review comment:
       i deliberately left `stdout` and `stderr` in case they were needed for deserialization.  but we don't normally persist tasks so this should be fine -- but one to remember.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org