You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2023/09/29 04:35:28 UTC

[GitHub] [arrow] AlenkaF opened a new issue, #37947: [Docs] New PyData Sphinx theme update bugs

AlenkaF opened a new issue, #37947:
URL: https://github.com/apache/arrow/issues/37947

### Describe the bug, including details regarding any error messages, version, and platform.

The Sphinx theme we have been using (PyData Sphinx Theme) has been pinned to an older version for a while now and with the [PR merged this week](https://github.com/apache/arrow/pull/36591) we have updated the code and are now using version 0.14.0 for the dev docs.

There are some issues that need to be fixed by the code freeze in 2 weeks. Will keep a list of those in this issue. Feel free to comment here and add extra bugs you might come across.

## List of issues on the new dev site:

- Top navigation bar and version warning bar are overlapping. The top navbar also overlaps the top content.
- Version switcher and icons for dark/light theme, github, etc. are overlapping.

- Arrow logo is overlapping top two banners on the mobile view

- Grid cards (main page, developers section) in dark mode have a white background
<img src="https://github.com/apache/arrow/assets/16418547/85e69d26-0ae0-4c6b-a63c-573c51d7c2cb" height="350"/>

### Component(s)

Documentation

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744421304

   Yes, I think that happens in the original theme also - could you check the picture I added in the previous comment just to check I am thinking of the correct part of the side navigation being hidden?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744377412

   Well, besides the vertical footprint, the problem is that it hides part of the side navigation panels as soon as one scrolls down.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744371189

   I think this will happen in any case when the window gets so small that it uses double header size, see the original theme:
   
   ![Screenshot 2023-10-03 at 09 33 10](https://github.com/apache/arrow/assets/16418547/27890c95-86e9-4700-880e-f5336adc12e8)
   
   If we find it very annoying I can open up an issue on the PyData theme repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF closed issue #37947: [Docs] New PyData Sphinx theme update bugs
URL: https://github.com/apache/arrow/issues/37947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF commented on issue #37947: [Docs] New PyData Sphinx theme update bugs

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1740551837

   Oh, I can not believe I already forgot about that!
   Thank you for reminding me and adding info to the issue for others to see.
   
   It works nicely for me now (no overlapping, no white background in the dark mode grid cards).
   
   Should we keep this open if anything else pops up or do we close it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] AlenkaF commented on issue #37947: [Docs] New PyData Sphinx theme update bugs

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1740976469

   Regarding the version switcher - if I look at the [theme web page](https://pydata-sphinx-theme.readthedocs.io/en/stable/index.html) the "Choose version" is displayed for stable version and "dev" for development. Older versions are using the old theme so can't tell.
   
   Will check if that is something we can change on our side.
   
   And for the header size, I agree. Will also add it to the TODO list on this issue description and see what I can do to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1746811048

   Upstream issue for the hidden sidebar top item when scrolling: https://github.com/pydata/pydata-sphinx-theme/issues/1493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on issue #37947: [Docs] New PyData Sphinx theme update bugs

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.

jorisvandenbossche commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1740710900

   One thing that doesn't work (unless this is intended to work differently in the version switcher of the theme) is showing the version of the docs you are looking at in the switcher:
   
   ![image](https://github.com/apache/arrow/assets/1020496/54d500bd-ea55-4b66-9708-30ed52a39b20)
   
   While on the stable or older docs it shows the version:
   
   ![image](https://github.com/apache/arrow/assets/1020496/ea190476-71fe-4a3a-8907-77313b969127)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744437358

   Here? (with the original theme I mean PyData Sphinx Theme)
   
   ![Screenshot 2023-10-03 at 10 10 19](https://github.com/apache/arrow/assets/16418547/9f18b149-498b-4f36-83fe-27e6e9382781)
   .
   .
   .
   and scrolling down
   .
   .
   .
   ![Screenshot 2023-10-03 at 10 10 26](https://github.com/apache/arrow/assets/16418547/048edb3b-45cf-4d03-9a4d-1d0c9f575c0d)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on issue #37947: [Docs] New PyData Sphinx theme update bugs

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.

jorisvandenbossche commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1740708558

   Let's maybe keep this issue open as the place to gather feedback or (design) bugs with the new theme.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744494558

   Oh, you are actually right Antoine. In our dev docs the sidebar gets hidden very soon when scrolling the page (not at the start, if you do not scroll down though!). But in the original theme it only happens when one gets to the end of the content.
   
   I guess this actually does happen because of the increased header height due to our logo.
   
   I am not sure if this is actually a bug or not, but will trust Joris on it.
   
   We could also use a different logo ourselves (for example: [Chevron-only](https://arrow.apache.org/img/arrow-logo_chevrons_black-txt_white-bg.png)). In this case there will be no need to resize the header. In the current case, when using [horizontal version of the logo](https://arrow.apache.org/img/arrow-logo_horizontal_black-txt_white-bg.png)), the logo gets very small and Apache part of it is not readable if the size is not increased. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.

jorisvandenbossche commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1755432149

   We could maybe also rename "Specifications and Protocol" to just "Specifications", that also makes the header a bit shorter, and thus less quickly to wraparound.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744422091

   I never encountered it in the original theme.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744499015

   > Oh, you are actually right Antoine. In our dev docs the sidebar gets hidden very soon when scrolling the page (not at the start, if you do not scroll down though!). But in the original theme it only happens when one gets to the end of the content.
   
   No, sorry, wrong again. I had a bigger window and the top navbar was only single header 🤦‍♀️  It actually happens in the original theme also - as is visible on the pictures I added before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on issue #37947: [Docs] New PyData Sphinx theme update bugs

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.

jorisvandenbossche commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1740455239

   > Top navigation bar and version warning bar are overlapping. The top navbar also overlaps the top content.
   
   You need to do a hard refresh .. (for me ctrl-F5), and then it all looks nice (we had the same issue a while ago with the documentation version switcher: https://github.com/apache/arrow/issues/37357). It's a bit annoying though


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.

jorisvandenbossche commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744462511

   > Well, besides the vertical footprint, the problem is that it hides part of the side navigation panels as soon as one scrolls down.
   
   If the header hides part of the sidebar when it becomes larger because of wrapping around on a second line, that sounds as a bug in the theme itself, IMO, and something we can report upstream.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744439763

   Ahah, yes, exactly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1752559168

   I have opened a PR for the first item on the list ([Change header size (top nav bar) for smaller screens](https://github.com/apache/arrow/issues/37947#issue-1918586132)) here: https://github.com/apache/arrow/pull/38148.
   
   I haven't found a solution for the second item on the list (_Version switcher button in the nav bar prints "Choose version" instead of the version you are currently have open (dev in our case)_) so I have opened an issue upstream: https://github.com/pydata/pydata-sphinx-theme/issues/1500.
   
   In case we do not find a solution for the version switcher text today, I would suggest to merge the PR for the header height on smaller screens to have it in the 14.0.0 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorisvandenbossche commented on issue #37947: [Docs] New PyData Sphinx theme update bugs

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.

jorisvandenbossche commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1740715773

   We could maybe also limit the size of the header / image when we are on a smaller screen, eg in mobile mode:
   
   ![image](https://github.com/apache/arrow/assets/1020496/08b41590-e00e-453e-9496-719ae4731487)
   
   (that's our overriding of `--pst-header-height`, it might be possible to only do that when on wide screens)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1743167550

   Same issue here with the top bar vertical size, which also hides part of the side navigation panels as soon as I scroll down:
   ![sphinx-theme](https://github.com/apache/arrow/assets/1721820/6c95dd30-cfa0-4ac2-b5d2-555604a41c2b)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.

pitrou commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744425728

   I'm thinking about these ones below:
   
   ![sphinx-theme2](https://github.com/apache/arrow/assets/1721820/bdc30917-59e9-46cd-9539-7d5cc2c9c5ee)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1744500992

   > ... something we can report upstream.
   (not sure if that's something that would be easy to solve, though)
   
   Agree, will add an issue upstream 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs] New PyData Sphinx theme update bugs [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.

AlenkaF commented on issue #37947:
URL: https://github.com/apache/arrow/issues/37947#issuecomment-1853999454

   Closing this issue as both reported bugs have been fixed:
   
   - https://github.com/apache/arrow/pull/38148
   - https://github.com/apache/arrow/pull/38241


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org