[jira] [Resolved] (KAFKA-1140) Move the decoding logic from ConsumerIterator.makeNext to next

["Jun Rao (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao resolved KAFKA-1140.
----------------------------

    Resolution: Fixed

Thanks for the patch. +1 and committed to trunk.

> Move the decoding logic from ConsumerIterator.makeNext to next
> --------------------------------------------------------------
>
>                 Key: KAFKA-1140
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1140
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>            Assignee: Guozhang Wang
>             Fix For: 0.8.1
>
>         Attachments: KAFKA-1140.patch, KAFKA-1140_2013-11-25_12:53:17.patch, KAFKA-1140_2013-11-25_12:55:34.patch, KAFKA-1140_2013-11-26_14:41:00.patch, KAFKA-1140_2013-11-26_18:29:53.patch
>
>
> Usually people will write code around consumer like
> while(iter.hasNext()) {
> try {
>   msg = iter.next()
>   // do something
> }
> catch{
> }
> }
> ----
> However, the iter.hasNext() call itself can throw exceptions due to decoding failures. It would be better to move the decoding to the next function call.



--
This message was sent by Atlassian JIRA
(v6.1#6144)