[jira] [Commented] (TINKERPOP-1545) IncidentToAdjacentStrategy is buggy

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655489#comment-15655489 ] 

ASF GitHub Bot commented on TINKERPOP-1545:
-------------------------------------------

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/tinkerpop/pull/486

    TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

    https://issues.apache.org/jira/browse/TINKERPOP-1545
    
    Made `SimplePathStep` implement `PathProcessor` and `IncidentToAdjacentStrategy` skip all traversals that contain path processing steps.
    
    The first few test suites of `docker/builder -t -i -n` succeeded and I will let it run over night, but I'm confident, that nothing bad is gonna happen in the other test suites (otherwise I'm going to revert the next line tomorrow).
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1545

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #486
    
----
commit 54dbeaacaf6ccfaab8db9de8ce736243fe32b78e
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2016-11-10T23:00:03Z

    Made SimplePathStep implement PathProcessor and IncidentToAdjacentStrategy skip all traversals that contain path processing steps

----


> IncidentToAdjacentStrategy is buggy
> -----------------------------------
>
>                 Key: TINKERPOP-1545
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1545
>             Project: TinkerPop
>          Issue Type: Bug
>    Affects Versions: 3.1.4, 3.2.3
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>
> {{IncidentToAdjacentStrategy}} turns {{outE().inV().simplePath()}} into {{out().simplePath()}}, which will return a wrong result as soon as there is more than 1 edge between a pair of vertices.
> The set {{INVALIDATING_STEP_CLASSES}} should only contain {{PathProcessor.class}} and {{LambdaHolder.class}} Furthermore {{SimplePathStep}} should implement {{PathProcessor}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)