[GitHub] [arrow] kou commented on a change in pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

[GitBox <gi...@apache.org>]

kou commented on a change in pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#discussion_r540698086



##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -656,7 +656,7 @@ test_linux_wheels() {
 }
 
 test_macos_wheels() {
-  local py_arches="3.5m 3.6m 3.7m 3.8"
+  local py_arches="3.5m 3.6m 3.7m 3.8 3.9"

Review comment:
       Could you revert this and other macOS wheel support related changes?
   Let's work on macOS wheel support in separated pull request.

##########
File path: cpp/Brewfile
##########
@@ -25,7 +25,6 @@ brew "flatbuffers"
 brew "git"
 brew "glog"
 brew "grpc"
-brew "llvm"

Review comment:
       Can we revert this change?

##########
File path: dev/tasks/python-wheels/github.win.yml
##########
@@ -53,9 +53,9 @@ jobs:
         run: |
           echo "c:\\Miniconda\\condabin" >> $GITHUB_PATH
       - name: Build wheel
-        shell: bash
+        shell: cmd
         run: |
-          arrow/dev/tasks/python-wheels/win-build.bat
+          call arrow/dev/tasks/python-wheels/win-build.bat

Review comment:
       Sorry, could you revert this change by me? https://github.com/apache/arrow/pull/8386/commits/5e03e010bc65308452c95d51ed21f0baebebf059
   This was meaningless.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org