You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/06 11:36:06 UTC
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #382: Enabling Role based Users in Projects
Pearl1594 opened a new pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382
Enables creating role based users in projects
UI for feature: https://github.com/apache/cloudstack/pull/4128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654180901
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662432174
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2533)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#discussion_r448266337
##########
File path: src/components/view/ResourceView.vue
##########
@@ -101,6 +102,19 @@ export default {
this.networkService = response.listnetworksresponse.network[0]
})
}
+ if (this.resource.projectaccountname) {
+ var projectAccountList = []
+ api('listProjectAccounts', { projectid: this.resource.id }).then(response => {
+ projectAccountList = response.listprojectaccountsresponse.projectaccount
+ for (var pa in projectAccountList) {
+ if ((projectAccountList[pa].userid && 'fetchUser(projectAccountList[pa].userid)'.username === this.$store.getters.userInfo.username) ||
Review comment:
Why is this a string when it is a function call ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654092809
Please merge latest master and fix any conflicts? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662573922
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656246625
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-653472489
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654595742
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662010515
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-650116265
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654595594
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662428510
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655886328
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-645999409
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2054)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654184730
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2220)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662578020
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2540)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-645995529
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#discussion_r451341671
##########
File path: src/components/view/DetailsTab.vue
##########
@@ -33,6 +33,9 @@
<router-link :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
</div>
</div>
+ <div v-else-if="$route.path.startsWith('/project/') && item === 'account' && fetchProjectAdmins()">
Review comment:
@Pearl1594 is this necessary now, if there's a new tab that has the details?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-652895990
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2191)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-647942012
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654289564
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654290144
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-650919863
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-649981115
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-653369615
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2199)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-653476044
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2200)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-650115855
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655274603
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-647567496
@rhtyd Could you please review the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655474414
@borisstoyanov a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#discussion_r451341908
##########
File path: src/components/view/DetailsTab.vue
##########
@@ -33,6 +33,9 @@
<router-link :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
</div>
</div>
+ <div v-else-if="$route.path.startsWith('/project/') && item === 'account' && fetchProjectAdmins()">
+ {{ fetchProjectAdmins() }}
Review comment:
This line could cause (needs checking I'm not sure) the API to be called twice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-650922691
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2157)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656048886
@rhtyd it is ready, however, wrt to the view of multiple project Admins if the list project API changes, there may be a small change in the UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#discussion_r451347430
##########
File path: src/components/view/DetailsTab.vue
##########
@@ -33,6 +33,9 @@
<router-link :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
</div>
</div>
+ <div v-else-if="$route.path.startsWith('/project/') && item === 'account' && fetchProjectAdmins()">
+ {{ fetchProjectAdmins() }}
Review comment:
As part of fetchProjectAdmins I'm not calling the listProjectAccounts API again, but rather just filters the resource parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-661946389
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2509)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656043912
@Pearl1594 is this ready again for review/testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-661940932
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662009631
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662573617
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656246028
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655274420
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-649980800
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-652838343
With @davidjumani for review/testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662427931
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-648683701
@Pearl1594 please advise when this is ready for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-652885964
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662523254
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2537)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662015086
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2512)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-653366707
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#discussion_r451347430
##########
File path: src/components/view/DetailsTab.vue
##########
@@ -33,6 +33,9 @@
<router-link :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
</div>
</div>
+ <div v-else-if="$route.path.startsWith('/project/') && item === 'account' && fetchProjectAdmins()">
+ {{ fetchProjectAdmins() }}
Review comment:
As part of fetchProjectAdmins I'm not calling the listProjectAccounts API again, but rather just filtering the resource parameters based on the role
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#discussion_r451348162
##########
File path: src/components/view/DetailsTab.vue
##########
@@ -33,6 +33,9 @@
<router-link :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
</div>
</div>
+ <div v-else-if="$route.path.startsWith('/project/') && item === 'account' && fetchProjectAdmins()">
Review comment:
This is necessary in case there are multiple project admins. So as to have the detail view also provide a comma-separated list as done in the list view
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655320460
@davidjumani can you review this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-653472063
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 closed pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 closed pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] borisstoyanov commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655473791
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-665670657
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655478514
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2259)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-645994907
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-661941647
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655276675
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2251)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654294786
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2225)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662517534
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-653366922
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-647946320
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2095)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-647942063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-652886584
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-653382249
@Pearl1594 Please check backward compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#discussion_r451347430
##########
File path: src/components/view/DetailsTab.vue
##########
@@ -33,6 +33,9 @@
<router-link :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
</div>
</div>
+ <div v-else-if="$route.path.startsWith('/project/') && item === 'account' && fetchProjectAdmins()">
+ {{ fetchProjectAdmins() }}
Review comment:
As part of fetchProjectAdmins I'm not calling the listProjectAccounts API again, but rather just filtering the resource parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654598111
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2230)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-647854780
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655343258
FYI @borisstoyanov @vladimirpetrov I'm merging due to dependency issues for other fixes Pearl has included in this PR; Pearl may send another PR if more issues are discovered during testing for the new feature. We expect this to not break env which don't have the new project-roles feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-650119792
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2142)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-653497808
LGTM. Backward compatible. Needs to be verified on the specific environment with the feature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655531029
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-654180486
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655886173
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-665670946
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-650919629
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656251123
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2266)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-662518090
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-655888222
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2260)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-649984687
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2138)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #382: Enabling Role based Users in Projects
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #382:
URL: https://github.com/apache/cloudstack-primate/pull/382#discussion_r451360014
##########
File path: src/components/view/DetailsTab.vue
##########
@@ -33,6 +33,9 @@
<router-link :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
</div>
</div>
+ <div v-else-if="$route.path.startsWith('/project/') && item === 'account' && fetchProjectAdmins()">
+ {{ fetchProjectAdmins() }}
Review comment:
Alright, let's merge this then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org