You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "John Lee (JIRA)" <ji...@apache.org> on 2010/11/05 15:02:45 UTC
[jira] Created: (HADOOP-7021) MapWritable NullPointerException
MapWritable NullPointerException
--------------------------------
Key: HADOOP-7021
URL: https://issues.apache.org/jira/browse/HADOOP-7021
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 0.20.1
Environment: Hadoop 0.20.1, Centos
Reporter: John Lee
Priority: Minor
Fix For: 0.20.1
We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085227#comment-13085227 ]
Hadoop QA commented on HADOOP-7021:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490322/HADOOP-7021.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/37//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/37//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/37//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/37//console
This message is automatically generated.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7021) MapWritable NullPointerException
Posted by "tom pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
tom pierce updated HADOOP-7021:
-------------------------------
Attachment: HADOOP-7021.patch
I tidied the new test a bit, putting it into the current TestMapWritable class and using UTF8 as the "foreign class" instead of a one-off example Writable.
Hopefully Hudson will find this patch more digestible; I followed the submission guidelines except for building the tar, which proved cumbersome on CentOS.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, HADOOP-7021.patch, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: (was: AbstractMapWritable.java)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work stopped] (HADOOP-7021) MapWritable
NullPointerException
Posted by "John Lee (Work stopped) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HADOOP-7021 stopped by John Lee.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: HADOOP-7021.patch
Updated patch using the the latest hadoop-common trunk. A code review is requested for this patch.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150977#comment-13150977 ]
John Lee commented on HADOOP-7021:
----------------------------------
Thanks for your help Doug.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: Open (was: Patch Available)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: HADOOP-7021.patch
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928631#action_12928631 ]
John Lee commented on HADOOP-7021:
----------------------------------
Could anyone help me out with properly submitting a patch and use Hudson? I have attached 3 files:
* AbstractMapWritable.diff which is the output of svn diff.
* AbstractMapWritable.java which is the full source with the patch.
* TestMapWritableNPE.java which is a unit test that demonstrates when the NullPointerException is thrown.
Thanks!
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085236#comment-13085236 ]
John Lee commented on HADOOP-7021:
----------------------------------
Does anyone know how to find out which tests did this patch fail?
-1 core tests. The patch failed these core unit tests:
Thanks!
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: Open (was: Patch Available)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: Open (was: Patch Available)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, HADOOP-7021.patch, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7021) MapWritable NullPointerException
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928615#action_12928615 ]
Hadoop QA commented on HADOOP-7021:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12458910/AbstractMapWritable.java
against trunk revision 1031422.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/57//console
This message is automatically generated.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: (was: HADOOP-7021.patch)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085246#comment-13085246 ]
John Lee commented on HADOOP-7021:
----------------------------------
Ran dev-support/test-patch.sh using the patch: http://issues.apache.org/jira/secure/attachment/12490322/HADOOP-7021.patch on a fresh svn checkout of hadoop-trunk and this is my output:
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version ) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 system test framework. The patch passed system test framework compile.
======================================================================
======================================================================
Finished build.
======================================================================
======================================================================
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: In Progress (was: Patch Available)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7021) MapWritable NullPointerException
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996872#comment-12996872 ]
Hadoop QA commented on HADOOP-7021:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12466768/HADOOP-7021.patch
against trunk revision 1071364.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1074 javac compiler warnings (more than the trunk's current 1072 warnings).
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/253//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/253//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/253//console
This message is automatically generated.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, HADOOP-7021.patch, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "Doug Cutting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150951#comment-13150951 ]
Doug Cutting commented on HADOOP-7021:
--------------------------------------
I assigned it to you. Can you now transition it back to Patch Available?
The best way to get some attention is to send a message to the dev mailing list, politely asking for someone to please look at this. I will try to have a look at it in a few days if I have a chance.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: HADOOP-7021.patch
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, HADOOP-7021.patch, HADOOP-7021.patch, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: Patch Available (was: Open)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-7021) MapWritable NullPointerException
Posted by "Doug Cutting (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting reassigned HADOOP-7021:
------------------------------------
Assignee: John Lee
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: Patch Available (was: Open)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151007#comment-13151007 ]
Hadoop QA commented on HADOOP-7021:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503833/HADOOP-7021.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/378//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/378//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/378//console
This message is automatically generated.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: (was: HADOOP-7021.patch)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7021) MapWritable NullPointerException
Posted by "tom pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
tom pierce updated HADOOP-7021:
-------------------------------
Affects Version/s: 0.21.0
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, HADOOP-7021.patch, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: Patch Available (was: Open)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "tom pierce (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177754#comment-13177754 ]
tom pierce commented on HADOOP-7021:
------------------------------------
Any reason this hasn't made it in yet? Seems like every time John manages to get Hudson to look at this patch, there's some unrelated (or at least not locally reproducable) problem that causes a -1...
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: Open (was: Patch Available)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7021) MapWritable NullPointerException
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974081#action_12974081 ]
Hadoop QA commented on HADOOP-7021:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12466768/HADOOP-7021.patch
against trunk revision 1051659.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1050 javac compiler warnings (more than the trunk's current 1048 warnings).
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/146//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/146//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/146//console
This message is automatically generated.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, HADOOP-7021.patch, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: HADOOP-7021.patch
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: Patch Available (was: Open)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Status: Patch Available (was: Open)
Received -1 overall but that was due to warnings in findbugs and javadocs which are unrelated to the code introduced by the patch. Resubmitting for review.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.21.0, 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: AbstractMapWritable.java
AbstractMapWritable.diff
TestMapWritableNPE.java
Attached are a patch to AbstractMapWritable and unit test that demonstrates the NullPointerException for current version of MapWritable.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150848#comment-13150848 ]
John Lee commented on HADOOP-7021:
----------------------------------
I accidentally changed the status of this issue to "In Progress" and I can not change it back to "Patch Available" could someone assist me with this?
Also, I have noticed that this issue was submitted more than a year ago (with code to fix the issue), since then I have updated the patch and test code for formatting and to be compatible with the update build layout. Is there anything else that need to done to get this patch review and committed? Thanks.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: (was: AbstractMapWritable.diff)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: HADOOP-7021.patch
Updated patch to reflect mvn directory structure.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Assignee: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Attachment: (was: TestMapWritableNPE.java)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076133#comment-13076133 ]
John Lee commented on HADOOP-7021:
----------------------------------
Thanks Uma for checking the patch. Following you comments I have removed the tabs.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7021) MapWritable NullPointerException
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076062#comment-13076062 ]
Uma Maheswara Rao G commented on HADOOP-7021:
---------------------------------------------
Hi Jhon,
Your patch contains hardcore tabs, can you remove them?
Also configure your IDE with correct coding formatter rules. Hadoop indentation is two spaces.
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1, 0.21.0
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: HADOOP-7021.patch, HADOOP-7021.patch
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7021) MapWritable NullPointerException
Posted by "John Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7021:
-----------------------------
Release Note: Found a NullPointerException with MapWritable. The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called.
Status: Patch Available (was: Open)
> MapWritable NullPointerException
> --------------------------------
>
> Key: HADOOP-7021
> URL: https://issues.apache.org/jira/browse/HADOOP-7021
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.1
> Environment: Hadoop 0.20.1, Centos
> Reporter: John Lee
> Priority: Minor
> Fix For: 0.20.1
>
> Attachments: AbstractMapWritable.diff, AbstractMapWritable.java, TestMapWritableNPE.java
>
>
> We have encountered a NullPointerException when we use MapWritable with custom Writable objects.
> The root cause is the counter newClasses in AbstractMapWritable is allowed to get out of sync with the id to class mapping tables when addToMap(Class) is called. We have a patch to AbstractMapWritable.addToMap(Class) that handles the case when newClasses gets out of sync with the id to class mapping tables and adds a serialization optimization to minimize the number of class names to write out per MapWritable object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.