[GitHub] [openjpa] struberg commented on pull request #65: [OPENJPA-2817] dropping _transforming from PCClassFileTransformer and replace it by a minimal exclusion list

[GitBox <gi...@apache.org>]

struberg commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658421421


   I still wonder if this whole `_transforming` boolean is a bit gone wrong?
   
   A.) it is set in a different method than cleared! For no apparent reason. This is not per se wrong, but a sign that the 'design' was not really clear.
   
   B.) There is already a method `needsEnhance` in `transform0`. This alone would probably be enough to guard us?
   The _transform flag blocks ANY recursive definition. That includes any other entity class you hit while transforming this class.
   We get likely saved by all those classes will be enhanced later on anyway. Is this intentionally or by accident?
   
   C.) Can't we get into troubles also in other cases in parallel CL mode? 
   
   I also don't really like the string matching. But I likely need one more day to get my head around the full complexity.
   
   Btw, fun to still see things like `OpenJpaException ke` where ke most likely stands for 'KodoException' :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org