You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/17 11:44:11 UTC

[GitHub] [pulsar] poorbarcode commented on pull request #18877: [fix] [broker] getLastMessageId returns a wrong batch index of last message if enabled read compacted

poorbarcode commented on PR #18877:
URL: https://github.com/apache/pulsar/pull/18877#issuecomment-1356223408

   Hi @gaoran10 
   
   > Maybe we can consider adding a property in message metadata to indicate the last valid message index, I'm afraid checking single metadata will cost too many resources if there are many messages in a batch.
   
   Good suggestion.
   
   I will fix it in another PR. To avoid modifying the definition of message metadata, I chose a different solution to improve the performance of extracting batched messages. see:
   - https://github.com/poorbarcode/pulsar/pull/50
   
   After the current PR is merged, I will push the PR above to the apache repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org