You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2015/12/21 07:49:29 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/558
ZEPPELIN-312: fix a bug with blocking websocket broadcast
### What is this PR for?
Fix the bug of Z, blocking broadcast to websocket connections.
### What type of PR is it?
Bug Fix
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-312
### How should this be tested?
See JIRA
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator-zeppelin fix/zeppelin-312-blocking-broadcast
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/558.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #558
----
commit 524c4017bab20a79859d6b36ace5a7debb253537
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-19T04:13:44Z
ZEPPELIN-312: refactoring ZeppelinServer to adhere Java naming conventions
commit 497a6cad361b78f659e026a9ebb18af267ecd843
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-21T06:34:01Z
ZEPPELIN-312: replace sync \w lock-free collection
Replacing synchronization though critical section over the collection of
sockets with the lock-free datastructure impl of
java.util.concurrent.ConcurrentLinkedQueue
Synchronization was used to avoid parallel collection modifications, as
the calls `.sendMessage()` in Jetty implementation of Websockets are
thread-safe and can proceed concurrently.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-168962911
@zenglinxi0615 could you please close #319 if the issue is solved?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166508540
CI passes now, @anthonycorbacho review was addressed in bbbf8ae
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by zenglinxi0615 <gi...@git.apache.org>.
Github user zenglinxi0615 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-168964104
closed just now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166509036
+1 Let's merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166541118
Cool, thank you for your kind feedback guys!
Merging if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166226640
CI failing looks irrelevant. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166231490
CI failure logged under https://issues.apache.org/jira/browse/ZEPPELIN-525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by zenglinxi0615 <gi...@git.apache.org>.
Github user zenglinxi0615 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166514034
@bzz ,sorry for my late response, and thanks for your work, it looks good for me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/558
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-312: fix a bug with bloc...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/558#issuecomment-166217507
This is another attempt, after #319
\cc @Leemoonsoo @zenglinxi0615 for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---