[jira] [Commented] (ARTEMIS-3950) dont prepare unused debug detail during xml data import processing

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583505#comment-17583505 ] 

ASF subversion and git services commented on ARTEMIS-3950:
----------------------------------------------------------

Commit 734e7f4ae52215566f4d51b2be2f62f810f63ab0 in activemq-artemis's branch refs/heads/main from Robbie Gemmell
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=734e7f4ae5 ]

ARTEMIS-3950: dont prepare unused debug detail during xml data import processing


> dont prepare unused debug detail during xml data import processing
> ------------------------------------------------------------------
>
>                 Key: ARTEMIS-3950
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3950
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.24.0
>            Reporter: Robbie Gemmell
>            Priority: Trivial
>             Fix For: 2.25.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The xml data import command for the cli prepares some details in a StringBuilder for use in debug logging. Though it does avoid calling toString() on the builder if the logger isnt enabled for debug output, it would be better not to prepare the detail at all since it takes various steps to do so including toString() of message metadata.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)