You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2017/10/05 21:09:37 UTC
[geode] 01/02: GEODE-3695 Remove unused protobuf messages from new
protocol
This is an automated email from the ASF dual-hosted git repository.
bschuchardt pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git
commit 2c04972162b96aed07b3ff76144b2b22ed6582a1
Author: Bruce Schuchardt <bs...@pivotal.io>
AuthorDate: Thu Oct 5 13:49:21 2017 -0700
GEODE-3695 Remove unused protobuf messages from new protocol
removed ping messages
---
.../internal/cache/tier/sockets/MessageExecutionContext.java | 1 -
.../geode/protocol/protobuf/utilities/ProtobufUtilities.java | 2 +-
geode-protobuf/src/main/proto/clientProtocol.proto | 2 --
geode-protobuf/src/main/proto/server_API.proto | 11 +----------
4 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageExecutionContext.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageExecutionContext.java
index d1fc461..38f164a 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageExecutionContext.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageExecutionContext.java
@@ -86,7 +86,6 @@ public class MessageExecutionContext {
* Returns the statistics for recording operation stats. In a unit test environment this may not
* be a protocol-specific statistics implementation.
*
- * @return
*/
public ClientProtocolStatistics getStatistics() {
return statistics;
diff --git a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
index 4da8723..1bac88f 100644
--- a/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
+++ b/geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
@@ -84,7 +84,7 @@ public abstract class ProtobufUtilities {
/**
* Creates a protobuf (key, value) pair from unencoded data. if the value is null, it will be
- * unset in the {@link BasicTypes.Entry}.
+ * unset in the BasicTypes.Entry.
*
* The key MUST NOT be null.
*
diff --git a/geode-protobuf/src/main/proto/clientProtocol.proto b/geode-protobuf/src/main/proto/clientProtocol.proto
index 8dc3f57..f91949f 100644
--- a/geode-protobuf/src/main/proto/clientProtocol.proto
+++ b/geode-protobuf/src/main/proto/clientProtocol.proto
@@ -49,7 +49,6 @@ message Request {
RemoveRequest removeRequest = 6;
RemoveAllRequest removeAllRequest = 7;
-// PingRequest pingRequest = 41;
GetAvailableServersRequest getAvailableServersRequest = 42;
GetRegionNamesRequest getRegionNamesRequest = 43;
GetRegionRequest getRegionRequest = 44;
@@ -67,7 +66,6 @@ message Response {
ErrorResponse errorResponse = 13;
-// PingResponse pingResponse = 41;
GetAvailableServersResponse getAvailableServersResponse = 42;
GetRegionNamesResponse getRegionNamesResponse = 43;
GetRegionResponse getRegionResponse = 44;
diff --git a/geode-protobuf/src/main/proto/server_API.proto b/geode-protobuf/src/main/proto/server_API.proto
index ae608da..0ea77a8 100644
--- a/geode-protobuf/src/main/proto/server_API.proto
+++ b/geode-protobuf/src/main/proto/server_API.proto
@@ -23,19 +23,10 @@ package org.apache.geode.internal.protocol.protobuf;
import "basicTypes.proto";
-// PingResponse sends the same number back.
-message PingRequest {
- int32 sequenceNumber = 1;
-}
-
-message PingResponse {
- int32 sequenceNumber = 1;
-}
-
message GetAvailableServersRequest {
}
message GetAvailableServersResponse {
repeated Server servers = 1;
-}
\ No newline at end of file
+}
--
To stop receiving notification emails like this one, please contact
"commits@geode.apache.org" <co...@geode.apache.org>.