You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2012/11/22 05:20:58 UTC
[jira] [Created] (HBASE-7208) Transition Offline Snapshots to
ExternalExceptions
Jonathan Hsieh created HBASE-7208:
-------------------------------------
Summary: Transition Offline Snapshots to ExternalExceptions
Key: HBASE-7208
URL: https://issues.apache.org/jira/browse/HBASE-7208
Project: HBase
Issue Type: Sub-task
Components: snapshots
Affects Versions: hbase-6055
Reporter: Jonathan Hsieh
Fix For: hbase-6055
This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7208) Transition Offline Snapshots to
ForeignExceptions
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-7208:
----------------------------------
Attachment: pre-hbase-7208.v7.patch
hbase-7208.v7.patch
> Transition Offline Snapshots to ForeignExceptions
> -------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: hbase-7208.v6.patch, hbase-7208.v7.patch, pre-hbase-7208.v6.patch, pre-hbase-7208.v7.patch
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7208) Transition Offline Snapshots to
ExternalExceptions
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-7208:
----------------------------------
Attachment: pre-hbase-7208.v6.patch
> Transition Offline Snapshots to ExternalExceptions
> --------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: hbase-7208.v6.patch, pre-hbase-7208.v6.patch
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7208) Transition Offline Snapshots to
ExternalExceptions
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-7208:
----------------------------------
Status: Patch Available (was: Open)
> Transition Offline Snapshots to ExternalExceptions
> --------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: hbase-7208.v6.patch, pre-hbase-7208.v6.patch
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-7208) Transition Offline Snapshots to
ExternalExceptions
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh reassigned HBASE-7208:
-------------------------------------
Assignee: Jonathan Hsieh
> Transition Offline Snapshots to ExternalExceptions
> --------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7208) Transition Offline Snapshots to
ExternalExceptions
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504191#comment-13504191 ]
Jonathan Hsieh commented on HBASE-7208:
---------------------------------------
Reviewboard available here https://reviews.apache.org/r/8229/
> Transition Offline Snapshots to ExternalExceptions
> --------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: hbase-7208.v6.patch
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7208) Transition Offline Snapshots to
ExternalExceptions
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-7208:
----------------------------------
Attachment: hbase-7208.v6.patch
> Transition Offline Snapshots to ExternalExceptions
> --------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: hbase-7208.v6.patch
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7208) Transition Offline Snapshots to
ForeignExceptions
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-7208:
----------------------------------
Summary: Transition Offline Snapshots to ForeignExceptions (was: Transition Offline Snapshots to ExternalExceptions)
> Transition Offline Snapshots to ForeignExceptions
> -------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: hbase-7208.v6.patch, pre-hbase-7208.v6.patch
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7208) Transition Offline Snapshots to
ExternalExceptions
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504190#comment-13504190 ]
Jonathan Hsieh commented on HBASE-7208:
---------------------------------------
This looks like a big patch but most of it is mechanical due to a renames. Highlights of what has been done:
* Removed old error handling framework, many renames (HBaseException -> ExtenralException, failOnError -> rethrowException)
* Moved the body of snapshot functions into the SnapshotManager. Better encapsulation and makes exception layering much clearer (HMaster throws SerivceExceptions, SnapshotManager throws IO and HBaseSnapshot exn).
* Added cancel method to SnapshotSentinel
* Refactored DisabledTableSnapshotHandler into TakeSnapshotHandler (This is the online-scaffolding patch essentially)
* Converted *Task to Callable<Void> instead of Runnable so that Exceptions can be thrown normally if called in line and centralized use of the ExternalException infra to only where necessary.
Compared to previous version -- there are no generics, fewer classes, more straightforward errorhandling, and better encapsulation of snapshotting methods within the SnapshotManager.
> Transition Offline Snapshots to ExternalExceptions
> --------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: hbase-7208.v6.patch
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7208) Transition Offline Snapshots to
ExternalExceptions
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504195#comment-13504195 ]
Jonathan Hsieh commented on HBASE-7208:
---------------------------------------
Patch build ontop of Jesse's snapshots branch hash 8e58f35f98. pre-hbase-7208.v6 goes on top of a particular apache hbase commit, and then the hbase-7208.v6.patch can be applied on top of it.
This is also available here:
https://github.com/jmhsieh/hbase
jmhsieh/snapshot-work-1126-2 hash 25da4512 (one parent is working version, the other is the review ready version).
> Transition Offline Snapshots to ExternalExceptions
> --------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: hbase-7208.v6.patch, pre-hbase-7208.v6.patch
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7208) Transition Offline Snapshots to
ExternalExceptions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504198#comment-13504198 ]
Hadoop QA commented on HBASE-7208:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12554928/pre-hbase-7208.v6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 42 new or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3407//console
This message is automatically generated.
> Transition Offline Snapshots to ExternalExceptions
> --------------------------------------------------
>
> Key: HBASE-7208
> URL: https://issues.apache.org/jira/browse/HBASE-7208
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: hbase-7208.v6.patch, pre-hbase-7208.v6.patch
>
>
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException mechanisms.
> I'd like this to be done before attempt merging to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira