You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2024/02/21 03:56:57 UTC
[PR] Clean up webserver endpoints adding to audit log [airflow]
bbovenzi opened a new pull request, #37580:
URL: https://github.com/apache/airflow/pull/37580
Clean up when we actually want to log events. Remove a few other unused decorators, mostly on on redirect functions.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #37580:
URL: https://github.com/apache/airflow/pull/37580#issuecomment-1958847389
Specifically `test_action_logging_get_legacy_view` seems directly relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #37580:
URL: https://github.com/apache/airflow/pull/37580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #37580:
URL: https://github.com/apache/airflow/pull/37580#discussion_r1497059915
##########
airflow/config_templates/config.yml:
##########
@@ -1831,7 +1831,7 @@ webserver:
version_added: 2.3.0
type: string
example: ~
- default: "gantt,landing_times,tries,duration,calendar,graph,grid,tree,tree_data"
+ default: "gantt,landing_times,tries,duration,calendar,graph,grid,tree"
Review Comment:
I am in favour of redoing the list to get rid of legacy stuff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #37580:
URL: https://github.com/apache/airflow/pull/37580#issuecomment-1959897068
> Specifically `test_action_logging_get_legacy_view` seems directly relevant.
Fixed. Removed two unneeded tests and added a test for robots.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #37580:
URL: https://github.com/apache/airflow/pull/37580#discussion_r1496865632
##########
airflow/config_templates/config.yml:
##########
@@ -1831,7 +1831,7 @@ webserver:
version_added: 2.3.0
type: string
example: ~
- default: "gantt,landing_times,tries,duration,calendar,graph,grid,tree,tree_data"
+ default: "gantt,landing_times,tries,duration,calendar,graph,grid,tree"
Review Comment:
`tree_data` doesn't exist . Should we keep these legacy ones or redo this exclude list entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #37580:
URL: https://github.com/apache/airflow/pull/37580#discussion_r1498298441
##########
airflow/config_templates/config.yml:
##########
@@ -1831,7 +1831,7 @@ webserver:
version_added: 2.3.0
type: string
example: ~
- default: "gantt,landing_times,tries,duration,calendar,graph,grid,tree,tree_data"
+ default: "gantt,landing_times,tries,duration,calendar,graph,grid,tree"
Review Comment:
Ok! I removed it entirely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #37580:
URL: https://github.com/apache/airflow/pull/37580#discussion_r1498441335
##########
airflow/www/views.py:
##########
@@ -3737,7 +3709,6 @@ def datasets_summary(self):
)
@expose("/robots.txt")
- @action_logging
Review Comment:
We need to leave this one - it powers [this warning](https://github.com/apache/airflow/blob/d5d6f4b1885a99f5a5e3063dbd54e1f32700c1df/airflow/www/views.py#L1020-L1029).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #37580:
URL: https://github.com/apache/airflow/pull/37580#issuecomment-1958710658
Looks like there might be a couple test failures from this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #37580:
URL: https://github.com/apache/airflow/pull/37580#discussion_r1498448602
##########
airflow/www/views.py:
##########
@@ -3737,7 +3709,6 @@ def datasets_summary(self):
)
@expose("/robots.txt")
- @action_logging
Review Comment:
FIxed
##########
airflow/www/views.py:
##########
@@ -3737,7 +3709,6 @@ def datasets_summary(self):
)
@expose("/robots.txt")
- @action_logging
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #37580:
URL: https://github.com/apache/airflow/pull/37580#issuecomment-1960103817
@jedcunningham For some reason `test_user_defined_filter_and_macros_raise_error` is failing, but it doesn't failed if GET `rendered-templates` still has `@action_logging`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up webserver endpoints adding to audit log [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #37580:
URL: https://github.com/apache/airflow/pull/37580#discussion_r1497778187
##########
airflow/config_templates/config.yml:
##########
@@ -1831,7 +1831,7 @@ webserver:
version_added: 2.3.0
type: string
example: ~
- default: "gantt,landing_times,tries,duration,calendar,graph,grid,tree,tree_data"
+ default: "gantt,landing_times,tries,duration,calendar,graph,grid,tree"
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org