You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/04 21:00:34 UTC
[GitHub] [spark] kaxil opened a new pull request #28122: Add .asf.yaml to
control Github settings
kaxil opened a new pull request #28122: Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
We added this to Apache Airflow project ([PR](https://github.com/apache/airflow/pull/6689)) and I think it would be good to have the Spark's website at the top.
Also, this would allow Spark's PMC Members and committer to control common Github project settings by themselves without having to ask Apache INFRA team.
More info: https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories
We (Airflow PMC and Committers) used this file to enable Github issues and disable PR Merge button etc
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Explained above
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
n/a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28122:
[SPARK-31352] Add .asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609444404
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25538/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kaxil commented on issue #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609408345
> I think it seems fine to have. Mind filing a JIRA please? See also https://spark.apache.org/contributing.html
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609465151
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120841/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609444404
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25538/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #28122:
[SPARK-31352] Add .asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#discussion_r403727534
##########
File path: .asf.yaml
##########
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories
+---
+github:
+ description: "Apache Spark - A unified analytics engine for large-scale data processing"
+ homepage: https://spark.apache.org/
+ labels:
+ - python
Review comment:
Sounds good to me. Later we could revisit these tags but this is fine as a copy of the current ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609444106
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609444396
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28122:
[SPARK-31352] Add .asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609089009
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609816534
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28122:
[SPARK-31352] Add .asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609465151
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120841/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28122: Add .asf.yaml to
control Github settings
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28122: Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609363823
I think it seems fine to have. Mind filing a JIRA please? See also https://spark.apache.org/contributing.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28122: Add .asf.yaml to
control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28122: Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609089009
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28122:
[SPARK-31352] Add .asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609465147
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28122: Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28122: Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609088890
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28122:
[SPARK-31352] Add .asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609444396
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609465147
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28122: Add .asf.yaml to
control Github settings
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28122: Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609088890
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28122: [SPARK-31352]
Add .asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609444229
**[Test build #120841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120841/testReport)** for PR 28122 at commit [`3edad26`](https://github.com/apache/spark/commit/3edad26f45333acd5aee02297db50c8d187e5aef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609464859
**[Test build #120841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120841/testReport)** for PR 28122 at commit [`3edad26`](https://github.com/apache/spark/commit/3edad26f45333acd5aee02297db50c8d187e5aef).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122#issuecomment-609444229
**[Test build #120841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120841/testReport)** for PR 28122 at commit [`3edad26`](https://github.com/apache/spark/commit/3edad26f45333acd5aee02297db50c8d187e5aef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #28122: [SPARK-31352] Add
.asf.yaml to control Github settings
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #28122: [SPARK-31352] Add .asf.yaml to control Github settings
URL: https://github.com/apache/spark/pull/28122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org