You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/13 07:18:15 UTC

[GitHub] [airflow] potiuk opened a new pull request #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry

potiuk opened a new pull request #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry
URL: https://github.com/apache/airflow/pull/7710
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry
URL: https://github.com/apache/airflow/pull/7710#issuecomment-598634820
 
 
   CI Fails with:
   
   ```
   /opt/airflow/scripts/ci/in_container/check_environment.sh: line 203: DB_RESET: unbound variable
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry
URL: https://github.com/apache/airflow/pull/7710#issuecomment-598694616
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=h1) Report
   > Merging [#7710](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/421e7a26ddc6564ad6751b9e7a3fa1cf094ba56d?src=pr&el=desc) will **decrease** coverage by `22.39%`.
   > The diff coverage is `49.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7710/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7710      +/-   ##
   ==========================================
   - Coverage    86.9%   64.51%   -22.4%     
   ==========================================
     Files         906      905       -1     
     Lines       43800    43914     +114     
   ==========================================
   - Hits        38065    28329    -9736     
   - Misses       5735    15585    +9850
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `81.75% <100%> (-8.45%)` | :arrow_down: |
   | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `25.7% <16.66%> (-50.47%)` | :arrow_down: |
   | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `62.82% <20%> (-32%)` | :arrow_down: |
   | [airflow/providers/amazon/aws/hooks/base\_aws.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9iYXNlX2F3cy5weQ==) | `59.41% <23.21%> (-17.9%)` | :arrow_down: |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `14.18% <28.57%> (-76.51%)` | :arrow_down: |
   | [airflow/providers/amazon/aws/hooks/sagemaker.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zYWdlbWFrZXIucHk=) | `85.96% <76.47%> (-1.29%)` | :arrow_down: |
   | [airflow/providers/apache/spark/hooks/spark\_sql.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX3NxbC5weQ==) | `88.57% <80%> (-0.83%)` | :arrow_down: |
   | [...oviders/amazon/aws/operators/sagemaker\_training.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvc2FnZW1ha2VyX3RyYWluaW5nLnB5) | `97.29% <93.33%> (-2.71%)` | :arrow_down: |
   | [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | ... and [499 more](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=footer). Last update [421e7a2...da82958](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry
URL: https://github.com/apache/airflow/pull/7710#issuecomment-598694616
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=h1) Report
   > Merging [#7710](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/421e7a26ddc6564ad6751b9e7a3fa1cf094ba56d?src=pr&el=desc) will **decrease** coverage by `22.39%`.
   > The diff coverage is `49.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7710/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7710      +/-   ##
   ==========================================
   - Coverage    86.9%   64.51%   -22.4%     
   ==========================================
     Files         906      905       -1     
     Lines       43800    43914     +114     
   ==========================================
   - Hits        38065    28329    -9736     
   - Misses       5735    15585    +9850
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `81.75% <100%> (-8.45%)` | :arrow_down: |
   | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `25.7% <16.66%> (-50.47%)` | :arrow_down: |
   | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `62.82% <20%> (-32%)` | :arrow_down: |
   | [airflow/providers/amazon/aws/hooks/base\_aws.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9iYXNlX2F3cy5weQ==) | `59.41% <23.21%> (-17.9%)` | :arrow_down: |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `14.18% <28.57%> (-76.51%)` | :arrow_down: |
   | [airflow/providers/amazon/aws/hooks/sagemaker.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zYWdlbWFrZXIucHk=) | `85.96% <76.47%> (-1.29%)` | :arrow_down: |
   | [airflow/providers/apache/spark/hooks/spark\_sql.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX3NxbC5weQ==) | `88.57% <80%> (-0.83%)` | :arrow_down: |
   | [...oviders/amazon/aws/operators/sagemaker\_training.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvc2FnZW1ha2VyX3RyYWluaW5nLnB5) | `97.29% <93.33%> (-2.71%)` | :arrow_down: |
   | [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | ... and [499 more](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=footer). Last update [421e7a2...da82958](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry
URL: https://github.com/apache/airflow/pull/7710
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry
URL: https://github.com/apache/airflow/pull/7710#issuecomment-598694616
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=h1) Report
   > Merging [#7710](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/421e7a26ddc6564ad6751b9e7a3fa1cf094ba56d&el=desc) will **decrease** coverage by `0.49%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7710/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7710      +/-   ##
   ==========================================
   - Coverage   86.90%   86.41%   -0.50%     
   ==========================================
     Files         906      906              
     Lines       43800    43927     +127     
   ==========================================
   - Hits        38065    37958     -107     
   - Misses       5735     5969     +234     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
   | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0.00%> (-32.36%)` | :arrow_down: |
   | [airflow/providers/amazon/aws/hooks/base\_aws.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9iYXNlX2F3cy5weQ==) | `59.41% <0.00%> (-17.90%)` | :arrow_down: |
   | [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
   | [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `73.25% <0.00%> (-12.80%)` | :arrow_down: |
   | ... and [10 more](https://codecov.io/gh/apache/airflow/pull/7710/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=footer). Last update [421e7a2...da82958](https://codecov.io/gh/apache/airflow/pull/7710?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry
URL: https://github.com/apache/airflow/pull/7710#issuecomment-598745981
 
 
   I forgot to add help explanation. Added now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7710: [AIRFLOW-7054] Breeze has an option now to reset db at entry
URL: https://github.com/apache/airflow/pull/7710#issuecomment-598659128
 
 
   > CI Fails with:
   > 
   > ```
   > /opt/airflow/scripts/ci/in_container/check_environment.sh: line 203: DB_RESET: unbound variable
   > ```
   
   Not any more :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services