Re: [PR] [SPARK-47422][SQL] Support collated strings in array operations [spark]

["dbatomic (via GitHub)" <gi...@apache.org>]

dbatomic commented on code in PR #45563:
URL: https://github.com/apache/spark/pull/45563#discussion_r1528438712


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala:
##########
@@ -107,6 +107,7 @@ object TypeUtils extends QueryErrorsBase {
    */
   def typeWithProperEquals(dataType: DataType): Boolean = dataType match {
     case BinaryType => false
+    case _: StringType => false

Review Comment:
   `UTF8_BINARY` should remain `typeWithProperEquals`, right? Also, can we declare all binary collations as `typeWithProperEquals` (e.g. UNICDOE)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org