[GitHub] [incubator-doris] morningman commented on a change in pull request #4881: [Bug] Fix bug introduced by split RowsDelFiltered profile

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #4881:
URL: https://github.com/apache/incubator-doris/pull/4881#discussion_r521926003



##########
File path: be/src/olap/rowset/beta_rowset_reader.h
##########
@@ -48,7 +48,7 @@ class BetaRowsetReader : public RowsetReader {
 
     RowsetSharedPtr rowset() override { return std::dynamic_pointer_cast<Rowset>(_rowset); }
 
-    int64_t filtered_rows() override { return _stats->rows_del_filtered; }
+    int64_t filtered_rows() override { return _stats->rows_del_filtered + _stats->rows_conditions_filtered; }

Review comment:
       Add a comment for this method to notify that this method will be used for validation of schema change task, should be modified carefully.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org