You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/09/17 13:13:44 UTC
[GitHub] [datasketches-cpp] FluorineDog opened a new issue #236: kll_sketches throw exception when number of inserted data is small
FluorineDog opened a new issue #236:
URL: https://github.com/apache/datasketches-cpp/issues/236
```c++
#include <iostream>
#include <kll_sketch.hpp>
using namespace datasketches;
using namespace std;
int main()
{
using T = int8_t;
kll_sketch<T> kll;
int N = 3;
kll.update(-8);
kll.update(-8);
kll.update(-8);
auto blob = kll.serialize();
std::cout << "blobsize=" << blob.size() << std::endl;
auto kll2 = kll_sketch<T>::deserialize(blob.data(), blob.size());
return 0;
}
```
will lead to
> libc++abi: terminating with uncaught exception of type std::out_of_range: Insufficient buffer size detected: bytes available 29, minimum needed 32
Seems that `ensure_minimum_memory(size, 1ULL << preamble_ints);` in `kll_sketch_impl.hpp:578` is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on issue #236: kll_sketch throw exception when number of inserted data is small
Posted by GitBox <gi...@apache.org>.
jmalkin commented on issue #236:
URL: https://github.com/apache/datasketches-cpp/issues/236#issuecomment-925138017
A fix has been merged and we have started the vote process for a 3.2.0 release (which includes some changes to python, otherwise it'd be a patch release). It'll be a few days before the release is final, even if no issues with the release candidate, but there's no additional work needed on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin closed issue #236: kll_sketch throw exception when number of inserted data is small
Posted by GitBox <gi...@apache.org>.
jmalkin closed issue #236:
URL: https://github.com/apache/datasketches-cpp/issues/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org