You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/07/16 00:01:07 UTC

[GitHub] [airflow] hussein-awala commented on a diff in pull request #32628: Move default_celery.py to inside the provider

hussein-awala commented on code in PR #32628:
URL: https://github.com/apache/airflow/pull/32628#discussion_r1264585373


##########
airflow/providers/celery/executors/default_celery.py:
##########


Review Comment:
   Personally, I am not a fan of relying on Airflow configurations from providers. The reason for my stance is that providers can be installed on various versions of Airflow, and if we add a new feature relies on a new configuration, it may not be supported by older versions of Airflow. IMHO, it would be beneficial to explore alternative methods for configuring executors with a minimal usage of Airflow configurations.



##########
airflow/providers/celery/executors/celery_executor_utils.py:
##########
@@ -64,6 +64,7 @@
 
 if conf.has_option("celery", "celery_config_options"):
     celery_configuration = conf.getimport("celery", "celery_config_options")
+

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org