You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org> on 2026/05/26 12:05:11 UTC
Re: [PR] feat(extensions): adds chatbot P1-P2 [superset]
codeant-ai-for-open-source[bot] commented on code in PR #40433:
URL: https://github.com/apache/superset/pull/40433#discussion_r3303520759
##########
superset-frontend/src/extensions/ExtensionsList.tsx:
##########
@@ -50,6 +61,45 @@ const ExtensionsList: FunctionComponent<ExtensionsListProps> = ({
addDangerToast,
);
+ const [settings, setSettings] = useState<ExtensionSettings>({
+ active_chatbot_id: null,
+ enabled: {},
+ });
+
+ useEffect(() => {
+ SupersetClient.get({ endpoint: '/api/v1/extensions/settings' })
+ .then(({ json }) => setSettings(json.result))
+ .catch(() => addDangerToast(t('Failed to load extension settings.')));
+ }, [addDangerToast]);
+
+ const saveSettings = useCallback(
+ (patch: Partial<ExtensionSettings>) => {
+ const next = { ...settings, ...patch };
+ SupersetClient.put({
+ endpoint: '/api/v1/extensions/settings',
+ jsonPayload: next,
+ })
+ .then(({ json }) => {
+ setSettings(json.result);
+ addSuccessToast(t('Settings saved.'));
+ })
+ .catch(() => addDangerToast(t('Failed to save extension settings.')));
+ },
+ [settings, addDangerToast, addSuccessToast],
+ );
+
+ const toggleEnabled = useCallback(
+ (extensionId: string, enabled: boolean) => {
+ saveSettings({ enabled: { ...settings.enabled, [extensionId]: enabled } });
+ },
+ [settings, saveSettings],
+ );
+
+ const chatbotExtensions = useMemo(() => {
+ const chatbotIds = new Set(getRegisteredViewIds(CHATBOT_LOCATION));
+ return resourceCollection.filter(ext => chatbotIds.has(ext.id));
+ }, [resourceCollection]);
Review Comment:
**🟠Architect Review — HIGH**
The "Default chatbot" options are derived from `getRegisteredViewIds(CHATBOT_LOCATION)` inside a `useMemo` that only depends on `resourceCollection`, so because chatbot views register asynchronously during `initializeExtensions`, the picker can miss chatbots that register after the first render and never update in that session.
**Suggestion:** Recompute `chatbotExtensions` reactively when the chatbot location registry changes (e.g., via `subscribeToLocation`) or derive chatbot-capable extensions from backend metadata instead of a one-time registry snapshot so the picker always reflects the currently registered chatbots.
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a2d972d0a0204cf3ba81cb75ff952fd1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a2d972d0a0204cf3ba81cb75ff952fd1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood.
**Path:** superset-frontend/src/extensions/ExtensionsList.tsx
**Line:** 98:101
**Comment:**
*HIGH: The "Default chatbot" options are derived from `getRegisteredViewIds(CHATBOT_LOCATION)` inside a `useMemo` that only depends on `resourceCollection`, so because chatbot views register asynchronously during `initializeExtensions`, the picker can miss chatbots that register after the first render and never update in that session.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
##########
superset/extensions/settings.py:
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Admin settings persistence for extensions (active chatbot, enable/disable)."""
+
+from typing import Any
+
+from superset import db
+from superset.models.core import ExtensionEnabled, ExtensionSettings
+
+_SETTINGS_ROW_ID = 1
+
+
+def get_extension_settings() -> dict[str, Any]:
+ row = db.session.get(ExtensionSettings, _SETTINGS_ROW_ID)
+ enabled_rows = db.session.query(ExtensionEnabled).all()
+ return {
+ "active_chatbot_id": row.active_chatbot_id if row else None,
+ "enabled": {r.extension_id: r.enabled for r in enabled_rows},
+ }
+
+
+def update_extension_settings(body: dict[str, Any]) -> dict[str, Any]:
+ row = db.session.get(ExtensionSettings, _SETTINGS_ROW_ID)
+ if row is None:
+ row = ExtensionSettings(id=_SETTINGS_ROW_ID)
+ db.session.add(row)
+
+ if "active_chatbot_id" in body:
+ row.active_chatbot_id = body["active_chatbot_id"] or None
+
+ if "enabled" in body:
+ for extension_id, enabled in body["enabled"].items():
+ flag = db.session.get(ExtensionEnabled, extension_id)
+ if flag is None:
+ flag = ExtensionEnabled(extension_id=extension_id)
+ db.session.add(flag)
+ flag.enabled = bool(enabled)
Review Comment:
**🟠Architect Review — HIGH**
The new per-extension `enabled` flag is persisted in `extension_settings`/`extension_enabled` but never consulted when listing or serving extensions, so disabling an extension in admin settings does not actually prevent it from being loaded or its assets from being served.
**Suggestion:** Wire the `enabled` flags into the runtime: filter out disabled extensions when building `/api/v1/extensions/` (and when resolving `/api/v1/extensions/<publisher>/<name>` and the asset endpoint), and hook into `ExtensionsLoader`/`deactivateExtension` so disabled extensions are not initialized or remain active after a settings change.
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=071f1fb7e5bc442ca83ec4cf3b969e19&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=071f1fb7e5bc442ca83ec4cf3b969e19&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood.
**Path:** superset/extensions/settings.py
**Line:** 46:52
**Comment:**
*HIGH: The new per-extension `enabled` flag is persisted in `extension_settings`/`extension_enabled` but never consulted when listing or serving extensions, so disabling an extension in admin settings does not actually prevent it from being loaded or its assets from being served.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org