You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:59:26 UTC

[GitHub] [incubator-superset] serenajiang opened a new issue #9148: [Explore] persist options after the datasource is modified

serenajiang opened a new issue #9148:
URL: https://github.com/apache/incubator-superset/issues/9148


   **Is your feature request related to a problem? Please describe.**
   Not sure if this qualifies as a bug or a feature request.
   
   In chart explore view, when you click `Edit datasource` and save, it clears all the chart options. Even if no changes are made 😮
   
   **Describe the solution you'd like**
   Possible solutions:
   * Keep all chart options. Running the query could result in an error if the datasource edit significantly changed relevant columns/metrics
   * Keep all chart options and flag invalid options.
   * Remove invalid options
   
   **Describe alternatives you've considered**
   * Leaving things as they are. Maybe this behavior is intentional/too hard to change?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 commented on issue #9148: [Explore] persist options after the datasource is modified

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9148:
URL: https://github.com/apache/incubator-superset/issues/9148#issuecomment-650409132


   This was fixed by https://github.com/apache/incubator-superset/pull/10092


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 closed issue #9148: [Explore] persist options after the datasource is modified

Posted by GitBox <gi...@apache.org>.
etr2460 closed issue #9148:
URL: https://github.com/apache/incubator-superset/issues/9148


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org