You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/03/21 18:29:29 UTC

Review Request 19537: Add/Use support for apt get in resource management library.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19537/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5180
    https://issues.apache.org/jira/browse/AMBARI-5180


Repository: ambari


Description
-------

Add/Use support for apt get in resource management library.


Diffs
-----

  ambari-agent/src/main/python/resource_management/core/providers/__init__.py 64c32ce 
  ambari-agent/src/main/python/resource_management/core/providers/package/apt.py PRE-CREATION 
  ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py a3d02c2 
  ambari-agent/src/test/python/resource_management/TestPackageResource.py 9a9a5c1 

Diff: https://reviews.apache.org/r/19537/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 19537: Add/Use support for apt get in resource management library.

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19537/#review38132
-----------------------------------------------------------



ambari-agent/src/main/python/resource_management/core/providers/package/apt.py
<https://reviews.apache.org/r/19537/#comment70101>

           --force-yes
               Force yes; This is a dangerous option that will cause apt to continue without prompting if it is doing something potentially harmful. It
               should not be used except in very special situations. Using force-yes can potentially destroy your system! Configuration Item:
               APT::Get::force-yes.
    
    How about replacing it with assume-yes?


- Dmitro Lisnichenko


On March 21, 2014, 5:31 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19537/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 5:31 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5180
>     https://issues.apache.org/jira/browse/AMBARI-5180
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add/Use support for apt get in resource management library.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/resource_management/core/providers/__init__.py 64c32ce 
>   ambari-agent/src/main/python/resource_management/core/providers/package/apt.py PRE-CREATION 
>   ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py a3d02c2 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 9a9a5c1 
> 
> Diff: https://reviews.apache.org/r/19537/diff/
> 
> 
> Testing
> -------
> 
> mvn test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 19537: Add/Use support for apt get in resource management library.

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19537/#review38142
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On March 21, 2014, 6:10 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19537/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 6:10 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5180
>     https://issues.apache.org/jira/browse/AMBARI-5180
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add/Use support for apt get in resource management library.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/resource_management/core/providers/__init__.py 64c32ce 
>   ambari-agent/src/main/python/resource_management/core/providers/package/apt.py PRE-CREATION 
>   ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py a3d02c2 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 9a9a5c1 
> 
> Diff: https://reviews.apache.org/r/19537/diff/
> 
> 
> Testing
> -------
> 
> mvn test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 19537: Add/Use support for apt get in resource management library.

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19537/
-----------------------------------------------------------

(Updated March 21, 2014, 6:10 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5180
    https://issues.apache.org/jira/browse/AMBARI-5180


Repository: ambari


Description
-------

Add/Use support for apt get in resource management library.


Diffs (updated)
-----

  ambari-agent/src/main/python/resource_management/core/providers/__init__.py 64c32ce 
  ambari-agent/src/main/python/resource_management/core/providers/package/apt.py PRE-CREATION 
  ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py a3d02c2 
  ambari-agent/src/test/python/resource_management/TestPackageResource.py 9a9a5c1 

Diff: https://reviews.apache.org/r/19537/diff/


Testing
-------

mvn test


Thanks,

Andrew Onischuk


Re: Review Request 19537: Add/Use support for apt get in resource management library.

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19537/
-----------------------------------------------------------

(Updated March 21, 2014, 5:31 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5180
    https://issues.apache.org/jira/browse/AMBARI-5180


Repository: ambari


Description
-------

Add/Use support for apt get in resource management library.


Diffs
-----

  ambari-agent/src/main/python/resource_management/core/providers/__init__.py 64c32ce 
  ambari-agent/src/main/python/resource_management/core/providers/package/apt.py PRE-CREATION 
  ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py a3d02c2 
  ambari-agent/src/test/python/resource_management/TestPackageResource.py 9a9a5c1 

Diff: https://reviews.apache.org/r/19537/diff/


Testing (updated)
-------

mvn test


Thanks,

Andrew Onischuk