[GitHub] [arrow] wjones127 commented on pull request #12536: ARROW-13168: [C++][R] Enable runtime timezone database for Windows

[GitBox <gi...@apache.org>]

wjones127 commented on pull request #12536:
URL: https://github.com/apache/arrow/pull/12536#issuecomment-1057455673


   So timezone database seems to work, but methods that rely on `std::local` currently error with:
   
   ```
   Error (test-dplyr-funcs-datetime.R:344:3): extract month from timestamp
   Error: Invalid: Cannot find locale 'English_United States.1252': locale::facet::_S_create_c_locale name not valid
   C:/Users/voltron/arrow/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:1085  GetLocale(options.locale)
   C:/Users/voltron/arrow/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:1105  Make(ctx, *in.type)
   C:/Users/voltron/arrow/cpp/src/arrow/compute/exec.cc:700  kernel_->exec(kernel_ctx_, batch, &out)
   C:/Users/voltron/arrow/cpp/src/arrow/compute/exec.cc:641  ExecuteBatch(batch, listener)
   C:/Users/voltron/arrow/cpp/src/arrow/compute/exec/expression.cc:547  executor->Execute(arguments, &listener)
   C:/Users/voltron/arrow/cpp/src/arrow/compute/exec/expression.cc:533  ExecuteScalarExpression(call->arguments[i], input, exec_context)
   C:/Users/voltron/arrow/cpp/src/arrow/compute/exec/project_node.cc:91  ExecuteScalarExpression(simplified_expr, target, plan()->exec_context())
   C:/Users/voltron/arrow/cpp/src/arrow/compute/exec/exec_plan.cc:484  iterator_.Next()
   C:/Users/voltron/arrow/cpp/src/arrow/record_batch.cc:336  ReadNext(&batch)
   C:/Users/voltron/arrow/cpp/src/arrow/record_batch.cc:347  ReadAll(&batches)
   ```
   
   These do work if you set `Sys.setlocale("LC_TIME", "C")`. If I don't find a fix for this, I may consider only supporting the "C" locale on Windows. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org