[jira] [Resolved] (PARQUET-528) Fix flush() for RecordConsumer and implementations

["Cheng Lian (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PARQUET-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cheng Lian resolved PARQUET-528.
--------------------------------
    Resolution: Fixed

Issue resolved by pull request 325
[https://github.com/apache/parquet-mr/pull/325]

> Fix flush() for RecordConsumer and implementations
> --------------------------------------------------
>
>                 Key: PARQUET-528
>                 URL: https://issues.apache.org/jira/browse/PARQUET-528
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-mr
>    Affects Versions: 1.8.0, 1.8.1
>            Reporter: Liwei Lin
>            Assignee: Liwei Lin
>             Fix For: 1.9.0
>
>
> _+flush()+_ was added in _+RecordConsumer+_ and _+MessageColumnIO+_ to help implementing nulls caching.
> However, other _+RecordConsumer+_ implementations should also implements _+flush()+_ properly. For instance, _+RecordConsumerLoggingWrapper+_ and _+ValidatingRecordConsumer+_ should call _+delegate.flush()+_ in their _+flush()+_ methods, otherwise data might be mistakenly truncated.
> This ticket:
> - makes _+flush()+_ abstract in _+RecordConsumer+_
> - implements _+flush()+_ properly for all _+RecordConsumer+_ subclasses, specifically:
> -- _+RecordConsumerLoggingWrapper+_
> -- _+ValidatingRecordConsumer+_
> -- _+ConverterConsumer+_
> -- _+ExpectationValidatingRecordConsumer+_



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)