You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/01 18:59:10 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #8494: [SIP-15] Updating ISO 8601 regex match to make time optional

john-bodley opened a new pull request #8494: [SIP-15] Updating ISO 8601 regex match to make time optional
URL: https://github.com/apache/incubator-superset/pull/8494
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR  replaces the ISO 8601 regex for the `DateFilterControl` with `moment`'s parsing as it's viable for one to simply defined a date (or similar). 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### BEFORE 
   
   ![Screen Shot 2019-11-01 at 11 46 35 AM](https://user-images.githubusercontent.com/4567245/68048336-8ef50c80-fc9d-11e9-9a2d-6e852c0a292d.png)
   
   #### AFTER
   
   ![Screen Shot 2019-11-01 at 11 45 44 AM](https://user-images.githubusercontent.com/4567245/68048346-987e7480-fc9d-11e9-8aa3-b2d570dd5735.png)
   
   ### TEST PLAN
   
   Manually tested. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @etr2460 @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org